Closed Bug 1376602 Opened 3 years ago Closed 3 years ago

Ship version 1.2 of WebCompat Go Faster addon

Categories

(Web Compatibility :: Interventions, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: denschub, Assigned: denschub)

References

Details

Attachments

(2 files)

With two important patches, one of them being a startup performance fix for Quantum Flow (bug 1371442) and the other one is reducing code duplicity for easier maintenance (bug 1376573), we should release v1.2 and have it ride 56.
Felipe, since you reviewed the last few updates as well, I hope you don't mind if I ask you again. :) Since our main development is on GitHub and individual commit messages are not visible, let me explain what's in the patches.

Part 1 is a collection of two fixes we made to help the Quantum team.

The first commit in that patch is explained in bug 1376573: we replaced our own implementation of user agent overrides with something that leverages the existing `UserAgentOverrides.jsm`. One of the reason for this change is so that we can profit from any performance improvements made to this module, and also duplicating functionality if not needed is something we'd like to avoid.

The second commit we landed in Part 1 is from bug 1371442. Here, we delay our initialization until we receive the "useragentoverrides-initialized" notification, which we landed a week ago. This is done so we don't start initializing our modules during browser startup.

In part 2, I added the modules in our Extension to the browser_startup performance test, so we can be sure to not regress by accident.

Try run is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=2259b9f98703
Comment on attachment 8893812 [details]
Bug 1376602 - Part 1: Import sources for WebCompat Go Faster 1.2.

https://reviewboard.mozilla.org/r/164916/#review171858
Attachment #8893812 - Flags: review?(felipc) → review+
Comment on attachment 8893813 [details]
Bug 1376602 - Part 2: Add WebCompat Go Faster modules to browser_startup tests.

https://reviewboard.mozilla.org/r/164918/#review171860
Attachment #8893813 - Flags: review?(felipc) → review+
Thanks for the detailed explanations in the request, Dennis. It was really useful!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c1e1102bbc3
Part 1: Import sources for WebCompat Go Faster 1.2. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/c95150c0fe9d
Part 2: Add WebCompat Go Faster modules to browser_startup tests. r=Felipe
Keywords: checkin-needed
Uh, I'm sorry. Some people commited changes to the eslint files in our folders without we being aware of that, and I broke everything since we manage our sources on GitHub. Fixed our part of the story and fixed the code style remarks, new try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=61bb9f668de9eb3f6dff09222fe3db6d844609c3
Flags: needinfo?(dschubert)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3c53a1b60ea7
Part 1: Import sources for WebCompat Go Faster 1.2. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/ed88d73fcd86
Part 2: Add WebCompat Go Faster modules to browser_startup tests. r=Felipe
You need to log in before you can comment on or make changes to this bug.