Fix build error with --enable-jitspew on opt builds

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: sstangl, Assigned: sstangl)

Tracking

53 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
Created attachment 8881589 [details] [diff] [review]
0001-Fix-enable-jitspew-on-opt-builds-for-x86-x64.patch

Currently, --enable-optimize --enable-jitspew fails to build, with the following error:

> error: function ‘void js::jit::GenericAssembler::spew(const char*, ...)’ can never be inlined because it uses variable argument lists

This patch fixes that for x64.
Attachment #8881589 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8881589 [details] [diff] [review]
0001-Fix-enable-jitspew-on-opt-builds-for-x86-x64.patch

Review of attachment 8881589 [details] [diff] [review]:
-----------------------------------------------------------------

I fixed this so many times locally … thanks for making a bug and pushing a patch :)
Attachment #8881589 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Updated

4 months ago
Assignee: nobody → sstangl
Keywords: checkin-needed

Comment 2

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42e7b44ca1e4
Fix --enable-jitspew on opt builds for x86/x64. r=nbp
Keywords: checkin-needed

Comment 3

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/42e7b44ca1e4
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.