Closed
Bug 1376619
Opened 8 years ago
Closed 8 years ago
Fix build error with --enable-jitspew on opt builds
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Currently, --enable-optimize --enable-jitspew fails to build, with the following error:
> error: function ‘void js::jit::GenericAssembler::spew(const char*, ...)’ can never be inlined because it uses variable argument lists
This patch fixes that for x64.
Attachment #8881589 -
Flags: review?(nicolas.b.pierron)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8881589 [details] [diff] [review]
0001-Fix-enable-jitspew-on-opt-builds-for-x86-x64.patch
Review of attachment 8881589 [details] [diff] [review]:
-----------------------------------------------------------------
I fixed this so many times locally … thanks for making a bug and pushing a patch :)
Attachment #8881589 -
Flags: review?(nicolas.b.pierron) → review+
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sstangl
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42e7b44ca1e4
Fix --enable-jitspew on opt builds for x86/x64. r=nbp
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•