Closed Bug 1376636 Opened 7 years ago Closed 7 years ago

Accept AV1 even when vp9 is too slow for software decoding

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

The benchmark check conditions vp9 playback through MSE to avoid advertising it on devices where software decoding would be too slow. This interferes with people trying out our experimental AV1 support, so exempt it for now. Poor performance in a demo is less confusing than mysteriously rejecting the stream.
Assignee: nobody → giles
Depends on: 1368839
Comment on attachment 8881615 [details]
Bug 1376636 - Exempt AV1 decoding from the vp9 benchmark.

https://reviewboard.mozilla.org/r/152774/#review157932

::: commit-message-85f5d:3
(Diff revision 1)
> +Bug 1376636 - Exempt AV1 decoding from the vp9 benchmark. r?gerald
> +
> +Accept av1 video in the webm encoder even when we've determined

Shouldn't "encoder" be "decoder" instead?
Attachment #8881615 - Flags: review?(gsquelart) → review+
Comment on attachment 8881615 [details]
Bug 1376636 - Exempt AV1 decoding from the vp9 benchmark.

https://reviewboard.mozilla.org/r/152774/#review158258

::: dom/media/mediasource/MediaSource.cpp:122
(Diff revision 2)
>    if (mimeType == MEDIAMIMETYPE("video/webm")) {
>      if (!(Preferences::GetBool("media.mediasource.webm.enabled", false) ||
>            containerType->ExtendedType().Codecs().Contains(
>              NS_LITERAL_STRING("vp8")) ||
> +          containerType->ExtendedType().Codecs().Contains(
> +            NS_LITERAL_STRING("av1")) ||

This doesn't seem to actually fix the issue; I'm investigating further.
Depends on: 1377015
Comment on attachment 8881615 [details]
Bug 1376636 - Exempt AV1 decoding from the vp9 benchmark.

https://reviewboard.mozilla.org/r/152774/#review157932

> Shouldn't "encoder" be "decoder" instead?

Indeed it should, thanks!
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e4bdf5c1628
Exempt AV1 decoding from the vp9 benchmark. r=gerald
Backed out for Android build bustage:

https://hg.mozilla.org/integration/autoland/rev/8a29717e70082c313213f8a6e2e88d3873049181

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0e4bdf5c1628e5d227003d43e897b2676d3f35b4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=110589694&repo=autoland

[task 2017-06-29T00:57:24.758490Z] 00:57:24     INFO -  /home/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /home/worker/workspace/build/src/config/expandlibs_gen.py -o libdom_network.a.desc Unified_cpp_dom_network0.o
[task 2017-06-29T00:57:24.827283Z] 00:57:24     INFO -  cc1plus: error: to generate dependencies you must specify either -M or -MM
[task 2017-06-29T00:57:24.828569Z] 00:57:24     INFO -  /home/worker/workspace/build/src/config/rules.mk:1010: recipe for target 'Unified_cpp_media_mediasource0.o' failed
[task 2017-06-29T00:57:24.830942Z] 00:57:24     INFO -  gmake[5]: *** [Unified_cpp_media_mediasource0.o] Error 1
[task 2017-06-29T00:57:24.831029Z] 00:57:24     INFO -  gmake[5]: Leaving directory '/home/worker/workspace/build/src/obj-firefox/dom/media/mediasource'
[task 2017-06-29T00:57:24.831755Z] 00:57:24     INFO -  /home/worker/workspace/build/src/config/recurse.mk:73: recipe for target 'dom/media/mediasource/target' failed
[task 2017-06-29T00:57:24.831801Z] 00:57:24     INFO -  gmake[4]: *** [dom/media/mediasource/target] Error 2
Flags: needinfo?(giles)
Comment on attachment 8881615 [details]
Bug 1376636 - Exempt AV1 decoding from the vp9 benchmark.

https://reviewboard.mozilla.org/r/152774/#review158368

::: dom/media/mediasource/MediaSource.cpp:126
(Diff revision 3)
>      if (!(Preferences::GetBool("media.mediasource.webm.enabled", false) ||
>            containerType->ExtendedType().Codecs().Contains(
>              NS_LITERAL_STRING("vp8")) ||
> +          // FIXME: Temporary comparison with the full codecs attribute.
> +          // See bug 1377015.
> +          AOMDecoder::IsSupportedCodec(containerType->ExtendedType().Codecs().AsString()) ||

This line needs `#ifdef MOZ_AV1` protection too.
Flags: needinfo?(giles)
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df082cf31ede
Exempt AV1 decoding from the vp9 benchmark. r=gerald
https://hg.mozilla.org/mozilla-central/rev/df082cf31ede
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.