Closed
Bug 1376655
Opened 7 years ago
Closed 7 years ago
stylo: Stop doing EnsureSameStructsCached during the post-traversal
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
16.57 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
19.74 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
5.68 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
This is unnecessary overhead. I have patches.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dc04f35d83daafa18a87be2f4ce450f97fe6411
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=832f1f0fba283ea5ef1b6f89719d13b38a0079ee
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e5e7980c3be9314666636743739e16e6d52b9eb
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8881803 -
Flags: review?(emilio+bugs)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8881805 -
Flags: review?(emilio+bugs)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8881806 -
Flags: review?(emilio+bugs)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8881807 -
Flags: review?(emilio+bugs)
Updated•7 years ago
|
Attachment #8881803 -
Flags: review?(emilio+bugs) → review+
Comment 8•7 years ago
|
||
Comment on attachment 8881805 [details] [diff] [review] Part 2 - Don't call EnsureSameStructsCached in ServoRestyleManager. v1 Review of attachment 8881805 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/style/ServoStyleContext.h @@ +53,5 @@ > + uint64_t newBits = (ourBits ^ otherBits) & NS_STYLE_INHERIT_MASK; > + > +#define STYLE_STRUCT(name_, checkdata_cb) \ > + if (nsStyle##name_::kHasFinishStyle && newBits & NS_STYLE_INHERIT_BIT(name_)) { \ > + const nsStyle##name_* data = Servo_GetStyle##name_(ComputedValues()); \ PeekStyle##name_?
Attachment #8881805 -
Flags: review?(emilio+bugs) → review+
Updated•7 years ago
|
Attachment #8881806 -
Flags: review?(emilio+bugs) → review+
Updated•7 years ago
|
Attachment #8881807 -
Flags: review?(emilio+bugs) → review+
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Emilio Cobos Álvarez [:emilio] from comment #8) > Comment on attachment 8881805 [details] [diff] [review] > Part 2 - Don't call EnsureSameStructsCached in ServoRestyleManager. v1 > > Review of attachment 8881805 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: layout/style/ServoStyleContext.h > @@ +53,5 @@ > > + uint64_t newBits = (ourBits ^ otherBits) & NS_STYLE_INHERIT_MASK; > > + > > +#define STYLE_STRUCT(name_, checkdata_cb) \ > > + if (nsStyle##name_::kHasFinishStyle && newBits & NS_STYLE_INHERIT_BIT(name_)) { \ > > + const nsStyle##name_* data = Servo_GetStyle##name_(ComputedValues()); \ > > PeekStyle##name_? Per IRL discussion, the bit isn't set yet. And all this will just become a struct member access afte bug 1367904.
Comment 10•7 years ago
|
||
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d13cb72a5669 Use ServoStyleContext in more places. r=emilio https://hg.mozilla.org/integration/autoland/rev/378597d9a6c3 Don't call EnsureSameStructsCached in ServoRestyleManager. r=emilio https://hg.mozilla.org/integration/autoland/rev/0eb7e3863c5f Stop using EnsureSameStructsCached in ViewportFrame::UpdateStyle. r=emilio https://hg.mozilla.org/integration/autoland/rev/f3e0f0a4ab7b Move EnsureSameStructsCached to GeckoStyleContext. r=emilio
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d13cb72a5669 https://hg.mozilla.org/mozilla-central/rev/378597d9a6c3 https://hg.mozilla.org/mozilla-central/rev/0eb7e3863c5f https://hg.mozilla.org/mozilla-central/rev/f3e0f0a4ab7b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•