Closed
Bug 137669
Opened 22 years ago
Closed 22 years ago
Remove <nobr>
Categories
(Bugzilla :: User Interface, defect, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: jwbaker, Assigned: jwbaker)
References
Details
Attachments
(2 files)
747 bytes,
patch
|
justdave
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
760 bytes,
patch
|
justdave
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Assignee | ||
Comment 3•22 years ago
|
||
These are all the <nobr> in the whole tree. Somebody review me.
OS: Linux → All
Hardware: PC → All
Comment 4•22 years ago
|
||
Comment on attachment 79384 [details] [diff] [review] Remove <nobr> from list.atml r= justdave x2
Attachment #79384 -
Flags: review+
Comment 5•22 years ago
|
||
Comment on attachment 79383 [details] [diff] [review] Remove <nobr> from viewall.atml r= justdave x 2 Gee, if this weren't a cookie-cutter copy/paste out of the TT manual examples.... ;-)
Attachment #79383 -
Flags: review+
Assignee | ||
Comment 6•22 years ago
|
||
I don't check in. Over to you, Dave. (Hell, it's probably easier to just edit your tree than aply these patches)
Assignee: jwbaker → justdave
Status: ASSIGNED → NEW
Comment 7•22 years ago
|
||
I suppose there might be some debate whether we want \s or \s+ in there, but the likelyhood of two consecutive spaces in an attachment status isn't that great... hmmm... is there an HTML entity code for a non-breaking hyphen? Just had a thought we might want to consider that, since it's quite likely a browser would wrap on a hyphen, too.
Comment 8•22 years ago
|
||
we'll leave it assigned to you so you get tracked as a contributor :)
Assignee: justdave → jwbaker
Assignee | ||
Comment 9•22 years ago
|
||
The spec says that the user agent shall not make a line break at a '-' character.
Comment 10•22 years ago
|
||
Hmm, actually, the normal hyphen (-) is not supposed to be a line break. If you want a hyphen to allow a line break, you encode it as ­ or "soft hyphen". So we're fine in this case. see http://www.w3.org/TR/html401/struct/text.html#h-9.3.2 In it goes.
Comment 11•22 years ago
|
||
Checking in list.atml; /cvsroot/mozilla/webtools/bugzilla/template/default/attachment/list.atml,v <-- list.atml new revision: 1.8; previous revision: 1.7 done Checking in viewall.atml; /cvsroot/mozilla/webtools/bugzilla/template/default/attachment/viewall.atml,v <-- viewall.atml new revision: 1.6; previous revision: 1.5 done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 12•22 years ago
|
||
Important reading regarding the soft hyphen and wrap issues: http://www.cs.tut.fi/~jkorpela/html/nobr.html http://www.cs.tut.fi/~jkorpela/shy.html "We're fine" (see comment #10) if one only cares about (one particular version of) the HTML spec and not the practical browser implementations. Nobr has its uses - and unfortunately, no valid markup construct can currently achieve the same effects.
Comment 13•20 years ago
|
||
There are two nobr in following current two templates: template/en/default/global/useful-links.html.tmpl template/en/default/list/table.html.tmpl
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•