1376726 - DevTools - Developer Toolbar - gcli commands - cookie (e10s on - throws an error, e10s off - a wrong parameter value)

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P3)

Description

[janekptacijarabaci]

Attachment: devtools_toolbar_gcli_cookie.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.9) Gecko/20100101 Goanna/3.2 Firefox/45.9 PaleMoon/27.3.0
Build ID: 20170422220104

Steps to reproduce:

Go to: https://addons.mozilla.org/en-US/firefox/

The Main Menu: Tools - Web Developer - Developer Toolbar

An example:
cookie list



Actual results:

[e10s on] - throws an error - see an attachment:

Error: unsafe CPOW usage forbidden
Stack trace:
exec@resource://gre/modules/commonjs/toolkit/loader.js
-> resource://devtools/shared/gcli/commands/cookie.js:97:11
Requisition.prototype.exec/<@resource://gre/modules/commonjs/toolkit/loader.js
-> resource://devtools/shared/gcli/source/lib/gcli/cli.js:2085:16
...
cli.js:2056

[e10s off] - a wrong parameter value (Attributes) - see an attachment:

The parameter is always empty.



Expected results:

An example (patch):

----------

https://hg.mozilla.org/mozilla-central/file/472ee679901a/devtools/shared/gcli/commands/cookie.js#l102

From:
let cookie = enm.getNext().QueryInterface(Ci.nsICookie);

To:
let cookie = enm.getNext().QueryInterface(Ci.nsICookie2);

----------

https://hg.mozilla.org/mozilla-central/file/472ee679901a/devtools/shared/gcli/commands/cookie.js#l110

From:
secure: cookie.secure,
httpOnly: cookie.httpOnly,
sameDomain: cookie.sameDomain

To:
isDomain: cookie.isDomain, 
isHttpOnly: cookie.isHttpOnly, 
isSecure: cookie.isSecure, 
isSession: cookie.isSession,

----------

https://hg.mozilla.org/mozilla-central/file/472ee679901a/devtools/shared/gcli/commands/cookie.js#l170

From:
        let noAttrs = !cookie.secure && !cookie.httpOnly && !cookie.sameDomain;
        cookie.attrs = (cookie.secure ? "secure" : " ") +
                       (cookie.httpOnly ? "httpOnly" : " ") +
                       (cookie.sameDomain ? "sameDomain" : " ") +
                       (noAttrs ? l10n.lookup("cookieListOutNone") : " ");

To:
        let noAttrs = !cookie.isDomain && !cookie.isHttpOnly &&
            !cookie.isSecure && !cookie.isSession;
        cookie.attrs = ((cookie.isDomain ? "isDomain " : "") +
                       (cookie.isHttpOnly ? "isHttpOnly " : "") +
                       (cookie.isSecure ? "isSecure " : "") +
                       (cookie.isSession ? "isSession " : "") +
                       (noAttrs ? l10n.lookup("cookieListOutNone") : ""))
                       .trim();
----------

Comment 2

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
20180505220904

https://hg.mozilla.org/integration/autoland/json-pushes?changeset=b894fc314a09ff63d89a373d09a9c33f47efcc07&full=1

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Many commands are broken, unfortunately.  GCLI is slated for removal (bug 1429421).  This bug will likely be closed once that has happened.

Comment 4

[Firefox Bug Husbandry Bot]

Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.