1376727 - A frame is displayed around the buttons in debugger toolbar

Status: VERIFIED INVALID

(DevTools :: Debugger, defect)

Description

[Hani Yacoub, Desktop QA]

Attachment: New Debugger toolbar.png

[Affected versions]: 
Nightly 56.0a1

[Affected platforms]:
Platforms: Ubuntu 16.04

[Steps to reproduce]:
1. Go to https://devtools-html.github.io/debugger-examples/examples/todomvc/
2. Open Debugger.
3. Navigate to todo-view.js
4. Right click on the gutter, any line with written code (e.g line 34), select add a breakpoint.
5. Go back to todmvc and add a todo item in the UI or reload the page.
6. Click on any of the buttons from the toolbal (e.g "resume" button).

[Expected result]:
A frame should not be displayed around buttons in the toolbar.

[Actual result]:
A frame is displayed around the buttons in debugger toolbar.

Comment 1

[Jason Laster [:jlast]]

This should be fixed on nightly.

Comment 2

[jonathan]

The "frame" exists for accessibility for users to know where the active focus is for keyboard navigation or for users with eyesight problem to know what is currently targeted on the page. They shouldn't be outright removed without being replaced by some UX for focus/active states which should also be consistent throughout the UX with other buttons and triggers.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm not able to reproduce this on the Mac.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Can't seem to reproduce this on Windows either.  Is this a Linux specific bug?

Comment 5

[Tom Tromey :tromey]

(In reply to Bryan Clark (DevTools PM) [:clarkbw] from comment #4)
> Can't seem to reproduce this on Windows either.  Is this a Linux specific
> bug?

I still see it on Linux using an artifact build from yesterday.

Comment 6

[Tom Tromey :tromey]

... however it's not clear to me that it should be removed, see comment #2;
also I see it for nearly every button in the UI, not just the debugger.

Comment 7

[jonathan]

It reproduces in all active/focus states of buttons for Linux/Windows because that's how those systems work for accessibility. Firefox internally on Mac OS handles the states differently to reflect the way the OS works. So, the exact steps to trigger it for a Mac may be different.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Ok, then lets leave this as it is intended behavior.