1376762 - Firefox Nightly (56) 20170615+ crashes on exit (Windows 7 & 10 64bit)

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Aris]

Attachment: crash.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170626165718

Steps to reproduce:

Install/setup any build of Firefox 56 64bit released after 2017-06-16 on Windows 7 64bit.

- clean profile, no add-ons installed
- all plugins enabled/disabled (makes not difference)
- e10s enabled/disabled (makes not difference)
- removing all internal add-ons from "browser\features\" makes no difference

Run Firefox, exit Firefox and it crashes.


Actual results:

Crash window occurs (see screenshot).

No Firefox crashlog or similar only Windows crashlog:

Problemsignatur:
  Problemereignisname:	APPCRASH
  Anwendungsname:	firefox.exe
  Anwendungsversion:	56.0.0.6388
  Anwendungszeitstempel:	5953962e
  Fehlermodulname:	StackHash_3c7f
  Fehlermodulversion:	0.0.0.0
  Fehlermodulzeitstempel:	00000000
  Ausnahmecode:	c0000005
  Ausnahmeoffset:	000000000048075c
  Betriebsystemversion:	6.1.7601.2.1.0.256.48
  Gebietsschema-ID:	1031
  Zusatzinformation 1:	3c7f
  Zusatzinformation 2:	3c7f0d9d51012597583a807f5364f2c6
  Zusatzinformation 3:	baee
  Zusatzinformation 4:	baeeab1f5c256281132fb605315855f6

Lesen Sie unsere Datenschutzbestimmungen online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0407

Wenn die Onlinedatenschutzbestimmungen nicht verfügbar sind, lesen Sie unsere Datenschutzbestimmungen offline:
  C:\Windows\system32\de-DE\erofflps.txt



Expected results:

No crash should occur.

This issue is not present onf 32bit version of Firefox Nightly (56) 20170617+

Comment 1

[Aris]

I just repeated this test on a different PC with Windows 10 64bit (Creators Update) installed with everything up-to-date and the issue occurs there too.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/06/2017-06-16-03-02-07-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/06/2017-06-17-03-02-06-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fe809f57bf2287bb937c3422ed03a63740b3448b&tochange=bb8eab3c3ac4147848c4c85d628ba72029978665

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If you have time, you may want to pinpoint search manually by using "hourly" builds - https://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/
or half-automatically by using mozregression - https://mozilla.github.io/mozregression/
so this will speed up fixing the issue.

Comment 4

[DJ-Leith]

I can confirm all of this (except that I have not tested on Windows 10).
My tests were all done on Windows 7.

This bug is a possible duplicate of Bug 1374043

In my tests the 'first Windows 64 bit build' that had this issue
is 2017-06-15 (not 2017-06-16 that Aris ir reporting in Comment #0).

I wrote in that bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1374043#c23

<snip>
> 
> *** Summary to date ***
> 
> Tested Windows 32 bit builds (2017-06-14, 15, 16 and 17).
> All 'close normally'.
> 
> Tested Windows 64 bit builds (2017-06-14, 15, 16 and 17).
> 
> Version 56.0a1 (2017-06-14) (64-bit)
> Build ID 20170614030206
> 
> Is like the 32 bit builds, it closes normally.
> 
> However,
> Version 56.0a1 (2017-06-15) (64-bit)
> Build ID 20170615030208
> 
> (and 2017-06-16 and 2017-06-17) all have the 'Windows Crash' on Close.
> 
> The Regression is in 
> Version 56.0a1 (2017-06-15) (64-bit)
> Build ID 20170615030208
> 
> but it does not seem to be in the 32bit builds.

Bug 1374043 describes how I tested and has more screenshots.
This bug is, however, more concise.

DJ-Leith

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Aris - Could you confirm that it started for you in 2017-06-16 or it's like in DJ-Leith case in 2017-06-15 build?

Comment 6

[Aris]

Yes, I can confirm it actually started on 2017-06-15 build. I must have skipped them unintentionally.

Comment 7

[Aris]

Last good inbound:
https://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1497392734/

First bad inbound:
https://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1497393034/


Last good Nightly:
http://ftp.mozilla.org/pub/firefox/nightly/2017/06/2017-06-14-03-02-06-mozilla-central/

First bad Nightly:
http://ftp.mozilla.org/pub/firefox/nightly/2017/06/2017-06-15-03-02-08-mozilla-central/

Comment 8

[Alice0775 White]

[Tracking Requested - why for this release]:

According to comment #7, Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=45b5cadadc22bd1c0991cc14fdf6e3c4c6ccf73b&tochange=ce749cd8209a14e053fafab193c18bbffcbea5b9

Regressed by: ce749cd8209a	David Major — Bug 1372375: Avoid locks in EnsureWalkThreadReady during the profiler's critical section. r=mstange

Comment 9

[DJ-Leith]

Aris,
Thanks very much for filing this bug, updating the Summary
and making the first report at mozillazine.

It was because you noticed that the 64 bit build had an issue
but the 32 bit build did not (and because I did not have any
'Firefox crash reports') that I decided to attempt to find the Regression.

I said in the 11th Comment of bug 1374043
[https://bugzilla.mozilla.org/show_bug.cgi?id=1374043#c11 ]

(In reply to Matt Howell [:mhowell] from the 6th comment of that bug)
> I don't think this is updater related; it seems to be happening on every shutdown
> whether it's a restart for an update or not.

I think this is the key point. If Nightly is not 'stopping properly', and Windows
is detecting this as a Crash, then we might *also* have 'Updating issues'.

Remember, in my case, I am using Windows 7 64 bit OS (others are using
Windows 10 64 bit).

In order to find the approximate regression I decided to download
some recent ZIP builds for Windows (both 32 bit and 64 bit).

Remember in
http://forums.mozillazine.org/viewtopic.php?f=23&t=3031109
cited in from Comment no 1 of that bug
[https://bugzilla.mozilla.org/show_bug.cgi?id=1374043#c1 ]

"Aris" said (Posted June 16th, 2017, 11:14 am):
> 64bit Nightly crashes on exit even with a clean empty profile. Can someone confirm?
> Win7 x64 / Nightly x64
> 
> 32bit Nightly seems not to be affected.

Link to his Post
http://forums.mozillazine.org/viewtopic.php?p=14752415#p14752415


Thanks too, to Virtual_ManPL and Alice0775 White for finding the regression.


I firmly believe that this bug is contributing to the 'Nightly updating issues',
seen since 2017-06-15, on Windows Nightly 64 bit builds.

Bug 1372375 is a very plausible candidate for the underlying cause.

DJ-Leith

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

I'll track this for 56 - Let's wait and see what dmajor thinks about this.

Comment 11

[Aris]

Inbound https://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64/1499284880/ seems to fix the problem.

Comment 12

[Aris]

Fixed on todays Nightly as well.