Closed Bug 1376763 Opened 4 years ago Closed 3 years ago

Investigate why many DidComposite messages are not labeled

Categories

(Core :: Graphics: Layers, enhancement)

Product:
Core
Component:
Graphics: Layers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: billm, Unassigned)

References

Details

(Whiteboard: [gfx-noted]) 

Bug 1333968 was supposed to label the DidComposite message. However, it seems that about 6% of DidComposite messages end up not having a label. I'm guessing that's because we take this branch:
http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/gfx/layers/ipc/CompositorManagerChild.cpp#249

However, I can't figure out what the circumstances are where we would do that.

This is important because DidComposite messages are extremely common. Although only 6% of them are unlabeled, this still makes them the most common unlabeled message!

Another odd thing is that, despite the fix for bug 1337548, we still get about 3x as many DidComposite messages as vsync messages. That seems odd.
See Also: → 1337548
Whiteboard: [gfx-noted]
See Also: → 1349991
The data here was incorrect because of bug 1380880. The issue with there being many more DidComposite messages than Vsyncs is still extant, but 1349991 will hopefully fix that,
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.