Closed
Bug 1376782
Opened 7 years ago
Closed 7 years ago
Unify gfxPoint, gfxMargin etc. with types in gfx/2d/
Categories
(Core :: Graphics, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(3 files)
There's some duplicated code here that we can get rid of. gfxPoint already extends from BasePoint but we can reduce it to being simply a typedef of PointDouble. Same for margin and size types. I intend to do the matrix and rect types as well but those are more complex so maybe I'll punt those to a follow-up bug.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b07213a52df2f7a1b41c7f843f172e37187ff03
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8881860 [details] Bug 1376782 - Replace gfxMargin with a typedef to MarginDouble. https://reviewboard.mozilla.org/r/152924/#review158094
Attachment #8881860 -
Flags: review?(jmuizelaar) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8881861 [details] Bug 1376782 - Replace gfxSize with a typedef to SizeDouble. https://reviewboard.mozilla.org/r/152926/#review158100
Attachment #8881861 -
Flags: review?(jmuizelaar) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8881862 [details] Bug 1376782 - Replace gfxPoint with a typedef to PointDouble. https://reviewboard.mozilla.org/r/152928/#review158108
Attachment #8881862 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e6b53822f7c Replace gfxMargin with a typedef to MarginDouble. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/9b91d24a1e30 Replace gfxSize with a typedef to SizeDouble. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/5b8646741e8f Replace gfxPoint with a typedef to PointDouble. r=jrmuizel
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e6b53822f7c https://hg.mozilla.org/mozilla-central/rev/9b91d24a1e30 https://hg.mozilla.org/mozilla-central/rev/5b8646741e8f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•