Unify gfxPoint, gfxMargin etc. with types in gfx/2d/

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

There's some duplicated code here that we can get rid of. gfxPoint already extends from BasePoint but we can reduce it to being simply a typedef of PointDouble. Same for margin and size types. I intend to do the matrix and rect types as well but those are more complex so maybe I'll punt those to a follow-up bug.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8881860 [details]
Bug 1376782 - Replace gfxMargin with a typedef to MarginDouble.

https://reviewboard.mozilla.org/r/152924/#review158094
Attachment #8881860 - Flags: review?(jmuizelaar) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8881861 [details]
Bug 1376782 - Replace gfxSize with a typedef to SizeDouble.

https://reviewboard.mozilla.org/r/152926/#review158100
Attachment #8881861 - Flags: review?(jmuizelaar) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8881862 [details]
Bug 1376782 - Replace gfxPoint with a typedef to PointDouble.

https://reviewboard.mozilla.org/r/152928/#review158108
Attachment #8881862 - Flags: review?(jmuizelaar) → review+

Comment 8

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e6b53822f7c
Replace gfxMargin with a typedef to MarginDouble. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9b91d24a1e30
Replace gfxSize with a typedef to SizeDouble. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5b8646741e8f
Replace gfxPoint with a typedef to PointDouble. r=jrmuizel

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e6b53822f7c
https://hg.mozilla.org/mozilla-central/rev/9b91d24a1e30
https://hg.mozilla.org/mozilla-central/rev/5b8646741e8f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.