Closed Bug 1376794 Opened 2 years ago Closed 2 years ago

Label blob IPC messages

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: billm, Assigned: baku)

References

Details

Attachments

(1 file)

This bug will cover the labeling of:
  PContent::Msg_PIPCBlobInputStreamConstructor
  PContent::Msg_BlobURLRegistration
  PContent::Msg_BlobURLUnregistration
...and any other blob-related messages.
Is this bug about setting the event target? https://wiki.mozilla.org/Quantum/DOM#IPC_Actors ?
Flags: needinfo?(wmccloskey)
(In reply to Andrea Marchesini [:baku] from comment #1)
> Is this bug about setting the event target?
> https://wiki.mozilla.org/Quantum/DOM#IPC_Actors ?

Yes. We'll probably need to use a different mechanism though. The patch in bug 1372433 has an example of how to do that (implementing the GetSpecificMessageEventTarget method on ContentChild).

Hopefully these messages don't actually touch a page's DOM. In that case, we could label them with the SystemGroup. If they do affect the DOM in ways that are observable to the page, we'll have to figure out something else to do.
Flags: needinfo?(wmccloskey)
These IPC messages do not touch DOM.
Assignee: nobody → amarchesini
Attachment #8883985 - Flags: review?(wmccloskey)
Comment on attachment 8883985 [details] [diff] [review]
blob_labeling.patch

Review of attachment 8883985 [details] [diff] [review]:
-----------------------------------------------------------------

This does seem pretty safe. In theory someone could observe that a blob URI was invalid and then it becomes valid in the middle of an event handler. But I don't think I care very much about that.
Attachment #8883985 - Flags: review?(wmccloskey) → review+
Andrea, can this patch be landed?
Flags: needinfo?(amarchesini)
no. it's not green on try. I have to find a better solution.
Flags: needinfo?(amarchesini)
Note: PContent::Msg_BlobURL(Re|Unre)gistration are landed in bug 1394357 and PContent::Msg_PIPCBlobInputStreamConstructor is landed in 1394350.
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/5f1cc2ce82b2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.