1376796 - Label the nsCaret::CaretBlinkCallback_timer

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think we'll need to label this with a TabGroup. I see that nsCaret has a pointer to a pres shell, so maybe we could use that to find a document to label it with.

Since this is a timer, we can use SetTarget and pass document->EventTargetFor(...).

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Label the nsCaret::CaretBlinkCallback_timer.

Hey Cameron,

May I have your review for this change?

Thanks!

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8893222 [details] [diff] [review]
(v1) Patch: Label the nsCaret::CaretBlinkCallback_timer.

Review of attachment 8893222 [details] [diff] [review]:
-----------------------------------------------------------------

Re-balancing some of my review load. :-)

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98adfea224e74c6e4a70727838c76582ef07701a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3367ef7283a1
Label the nsCaret::CaretBlinkCallback_timer. r=heycam

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/321fecf23a68
Label the nsCaret::CaretBlinkCallback_timer. r=xidorn

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/321fecf23a68