Label the nsCaret::CaretBlinkCallback_timer

RESOLVED FIXED in Firefox 57

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: billm, Assigned: bevis)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

I think we'll need to label this with a TabGroup. I see that nsCaret has a pointer to a pres shell, so maybe we could use that to find a document to label it with.

Since this is a timer, we can use SetTarget and pass document->EventTargetFor(...).

Updated

11 months ago
Priority: -- → P3
(Assignee)

Comment 1

11 months ago
Created attachment 8893222 [details] [diff] [review]
(v1) Patch: Label the nsCaret::CaretBlinkCallback_timer.

Hey Cameron,

May I have your review for this change?

Thanks!
Assignee: nobody → btseng
Status: NEW → ASSIGNED
Attachment #8893222 - Flags: review?(cam)
Comment on attachment 8893222 [details] [diff] [review]
(v1) Patch: Label the nsCaret::CaretBlinkCallback_timer.

Review of attachment 8893222 [details] [diff] [review]:
-----------------------------------------------------------------

Re-balancing some of my review load. :-)
Attachment #8893222 - Flags: review?(cam) → review?(xidorn+moz)
Attachment #8893222 - Flags: review?(xidorn+moz) → review+

Comment 4

11 months ago
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3367ef7283a1
Label the nsCaret::CaretBlinkCallback_timer. r=heycam

Comment 5

11 months ago
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/321fecf23a68
Label the nsCaret::CaretBlinkCallback_timer. r=xidorn

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/321fecf23a68
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.