1376798 - 'use stage servers' switch should apply to sync, push, fxa setting

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement, P2)

Description

[No-Jun Park [:njpark]]

The debug menu "Debug: use stage servers" currently sets the sync server to staging.  After talking with the FxA QA, it looks like this switch should also set the fxa and push server to staging as well, since when a server of one service is set to staging, all other services should be set to staging as well.

ni?ing Richard if there's something I missed in explanation.

Comment 1

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to No-Jun Park [:njpark] from comment #0)
> The debug menu "Debug: use stage servers" currently sets the sync server to
> staging.  After talking with the FxA QA, it looks like this switch should
> also set the fxa and push server to staging as well, since when a server of
> one service is set to staging, all other services should be set to staging
> as well.
> 
> ni?ing Richard if there's something I missed in explanation.

When we do stage testing of a web service that requires other services we maintain (i.e. Hello firefox used FxA + loop-server), we typically make sure that any test client we use only points to the other web services within the stage IAM as well.  There are exceptions to this, but in general the stage environment often has configurations closely tied with other web services intended to work together in one environment.  Being able to switch from a production to stage configuration within the iOS client would be essential for doing deployment verification with autopush, Sync services to stage and prod.
Thanks!

Comment 2

[Richard Pappalardo [:rpapa][:rpappalardo]]

Also, when we do deployment verification testing, we need to always confirm ahead of time the connection settings for all the services we use (Fxa, Sync and autopush).  If that info is hidden on the client, we won't be able to confirm whether or not we're using stage or production.  If you could please display all the server settings on the client, that would be helpful.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

See also bug 1249520, where desktop may read an end-point from the FxA server to work out how to configure other various preferences.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/2871

This patch selects the autopush staging servers if you enable the secret menu option. Before this patch we only used the staging servers for FxA and Sync. Now we also switch to AutoPush.

This will work on Firefox, Firefox Beta and Fennec.

This is a request from QA so that they test on a consistent staging environment for all services that we talk to.

*Note* - For consistency, Fennec will also switch to Staging Servers. Before this patch it would switch to the Development version. I don't think that was actively used, if it was, we can re-introduce that or not make that change.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8882692 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/2871

R+ with comment. See PR.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on master, uplifted to v8.x