Closed Bug 1376859 Opened 3 years ago Closed 3 years ago

Update DrawTargetCapture's current transform during recording SetTransform

Categories

(Core :: Graphics, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Windows scrollbars were showing black because it queries the current transform of the target DT, applies a translation, then sets the transform. [1]. DrawTargetcapture wasn't actually updating the transform during recording, so further applied transforms would always be based off the identity matrix, which doesn't actually work. We should keep the transform updated as we record.

[1] http://searchfox.org/mozilla-central/source/gfx/thebes/gfxWindowsNativeDrawing.cpp#277
Attachment #8881847 - Flags: review?(dvander)
Summary: Update DrawTargetCapture's current transform during SetTransform → Update DrawTargetCapture's current transform during recording SetTransform
Attachment #8881847 - Attachment is obsolete: true
Attachment #8881847 - Flags: review?(dvander)
Attachment #8881849 - Flags: review?(dvander)
Blocks: omtp
Attachment #8881849 - Flags: review?(dvander) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9827df640423
Update DrawTargetCapture's current transform during recording SetTransform. r=dvander
https://hg.mozilla.org/mozilla-central/rev/9827df640423
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Blocks: 1379322
You need to log in before you can comment on or make changes to this bug.