Closed
Bug 1376859
Opened 7 years ago
Closed 7 years ago
Update DrawTargetCapture's current transform during recording SetTransform
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file, 1 obsolete file)
509 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Windows scrollbars were showing black because it queries the current transform of the target DT, applies a translation, then sets the transform. [1]. DrawTargetcapture wasn't actually updating the transform during recording, so further applied transforms would always be based off the identity matrix, which doesn't actually work. We should keep the transform updated as we record. [1] http://searchfox.org/mozilla-central/source/gfx/thebes/gfxWindowsNativeDrawing.cpp#277
Attachment #8881847 -
Flags: review?(dvander)
Assignee | ||
Updated•7 years ago
|
Summary: Update DrawTargetCapture's current transform during SetTransform → Update DrawTargetCapture's current transform during recording SetTransform
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8881847 -
Attachment is obsolete: true
Attachment #8881847 -
Flags: review?(dvander)
Attachment #8881849 -
Flags: review?(dvander)
Assignee | ||
Comment 2•7 years ago
|
||
Try all - https://treeherder.mozilla.org/#/jobs?repo=try&revision=b15b72417c0b0a22a6d6185076676feff577f956
Attachment #8881849 -
Flags: review?(dvander) → review+
Pushed by mchang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9827df640423 Update DrawTargetCapture's current transform during recording SetTransform. r=dvander
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9827df640423
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•