1376875 - Call Destroy() from LayerTransactionParent::ActorDestroy()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

To handle abnormal shutdown case, we need to call Destroy() from ActorDestroy().

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call Destroy() from LayerTransactionParent::ActorDestroy()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15d63befd945295ebbddf4615d4d66b14713613e

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa03375be18d
Call Destroy() from LayerTransactionParent::ActorDestroy() r=nical

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa03375be18d

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8881875 [details] [diff] [review]
patch - Call Destroy() from LayerTransactionParent::ActorDestroy()

Approval Request Comment
[Feature/Bug causing the regression]: The problem exists since Bug 825928, but it does not cause a harm by itself. The change is necessary for Bug 1376896.
[User impact if declined]:It is necessary for Bug 1376896. If Bug 1376896 is not up lifted, it could cause memory leak.
[Is this code covered by automated tests?]: passed try and land in central for a while
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This is necessary for Bug 1376896.
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: The change just added shut down handling to ActorDestroy(). LayerTransactionParent::Destroy() is already used for a long time.
[String changes made/needed]: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8881875 [details] [diff] [review]
patch - Call Destroy() from LayerTransactionParent::ActorDestroy()

same as bug 1376896