pageAction popup telemetry does not report the correct times

RESOLVED FIXED in Firefox 56

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: kmag, Assigned: bsilverberg)

Tracking

unspecified
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [metrics] triaged)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
We're currently reporting the time it takes to construct the PanelPopup instance, but this has nothing to do with how long it takes the popup to actually show. We need to wait for the `contentReady` promise to resolve before calling finish().
(Assignee)

Updated

2 years ago
Priority: -- → P2
Whiteboard: [metrics] triaged
(Reporter)

Comment 1

2 years ago
We're currently collecting and analyzing useless telemetry data, and we have a limited amount of time to collect data from this probe.
Priority: P2 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8881926 [details]
Bug 1376888 - pageAction popup telemetry does not report the correct times,

https://reviewboard.mozilla.org/r/152990/#review158200

::: browser/components/extensions/ext-pageAction.js:247
(Diff revision 1)
>        new PanelPopup(this.extension, this.getButton(window), popupURL,
>                       this.browserStyle);
> -      TelemetryStopwatch.finish(popupOpenTimingHistogram, this);

I'd rather we continue keeping all of the stopwatch logic here. We just need to wait until the appropriate time to call finish. Something like this should do:

    let popup = new PanelPopup(...);
    await popup.contentReady;
    TelemetryStopwatch.finish(...);
Attachment #8881926 - Flags: review?(kmaglione+bmo)
Comment hidden (mozreview-request)
(Reporter)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8881926 [details]
Bug 1376888 - pageAction popup telemetry does not report the correct times,

https://reviewboard.mozilla.org/r/152990/#review158204
Attachment #8881926 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb7da3a8a056
pageAction popup telemetry does not report the correct times, r=kmag

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb7da3a8a056
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

10 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.