1376921 - Remove the mips{32,64} back-end from the list of MacroAssembler supported backends.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Nicolas B. Pierron [:nbp]]

Currently check_macroassembler_style.py breaks because of the lack of implementation of mips32 / mips64.  As a work-around one can add MOZ_CRASH calls in dummy place-holders.

As of today, the mips32 backend does not compile.

So, I suggest to remove the mips backends from the list of supported targets checked by the check_macroassembler_style.py, and ignore the mips implementation until somebody takes over the support of mips backends once more.

Comment 1

[Lars T Hansen [:lth]]

Piling on: Last I looked, the MIPS backends had not been properly updated to support the things you did for the register sets.  MIPS32 seemed to require substantial work; MIPS64 was a bit easier.  I had patches in progress but never had time to finish them.  See bug 1329650.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: Remove mips from the list of checked MacroAssemblers.

Comment 3

[Ted Campbell [:tcampbell]]

Comment on attachment 8881949 [details] [diff] [review]
Remove mips from the list of checked MacroAssemblers.

Review of attachment 8881949 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Thanks for the clarifications.

Comment 4

[ivica.bogosavljevic]

Hello!

Myself and my good friend Dusan are interested in keeping MIPS ports alive. We uploaded some patches earlier, but not many things happened after that. We would be sorry to see MIPS support abandoned.

We will have a look at the compilation for MIPS32 backend and upload fixes. Are there any other burning issues on MIPS that we need to be aware of?

Comment 5

[Nicolas B. Pierron [:nbp]]

(In reply to ivica.bogosavljevic from comment #4)
> Myself and my good friend Dusan are interested in keeping MIPS ports alive.
> We uploaded some patches earlier, but not many things happened after that.
> We would be sorry to see MIPS support abandoned.

As you can see from the current patch, we have not removed the MIPS backends, at the moment.

We have no MIPS expertise, and these are not priorities for Mozilla at the moment.

This patch removes the check which enforces us to define dummy MOZ_CRASH functions to MIPS backends.  Which should make it easier for you to spot missing functions from compiler error messages.

> We will have a look at the compilation for MIPS32 backend and upload fixes.
> Are there any other burning issues on MIPS that we need to be aware of?

At the moment MIPS32 does not compile, and I did not had enough expertise to some of the functions needed for Bug 1364908.
If you need any help understanding our current API, feel free to come to the #jsapi channel of irc.mozilla.org.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f134dec63727
Remove mips from the list of checked MacroAssemblers. r=tcampbell

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f134dec63727

Comment 8

[ivica.bogosavljevic]

(In reply to Nicolas B. Pierron [:nbp] from comment #5)
> (In reply to ivica.bogosavljevic from comment #4)
> > Myself and my good friend Dusan are interested in keeping MIPS ports alive.
> > We uploaded some patches earlier, but not many things happened after that.
> > We would be sorry to see MIPS support abandoned.
> 
> As you can see from the current patch, we have not removed the MIPS
> backends, at the moment.
> 
> We have no MIPS expertise, and these are not priorities for Mozilla at the
> moment.
> 
> This patch removes the check which enforces us to define dummy MOZ_CRASH
> functions to MIPS backends.  Which should make it easier for you to spot
> missing functions from compiler error messages.
> 
> > We will have a look at the compilation for MIPS32 backend and upload fixes.
> > Are there any other burning issues on MIPS that we need to be aware of?
> 
> At the moment MIPS32 does not compile, and I did not had enough expertise to
> some of the functions needed for Bug 1364908.
> If you need any help understanding our current API, feel free to come to the
> #jsapi channel of irc.mozilla.org.

We have a lot of MIPS expertise, also we have resources to perform the tests on actual hardware. We also have some expertise in JavaScript compilers, but no experience in SpiderMonkey.