1376928 - Reduce includes in jit/Recover.h

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

As discussed in bug 1367088, comment #7, jit/Recover.h shouldn't include jit/MIR.h.

Comment 1

[André Bargull [:anba]]

Attachment: bug1376928.patch

Simply changes the MNewObject::Mode field to a raw uint8. And the jsarray.h includes is also no longer needed, so I removed it as well.

Comment 2

[André Bargull [:anba]]

Comment on attachment 8881945 [details] [diff] [review]
bug1376928.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8448715a4960c5258f7c4536060baf3d0c14b6d shows failures in generated static_asserts in non-unified builds. So it's not yet ready for review.

Comment 3

[André Bargull [:anba]]

Turns out that Recover.h is only included in four cpp-files, so it's probably not worth the trouble to remove the MIR.h include from it:
  js/src/jit/BaselineBailouts.cpp
  js/src/jit/JitFrames.cpp
  js/src/jit/Recover.cpp
  js/src/jit/Snapshots.cpp

Comment 4

[Nicolas B. Pierron [:nbp]]

js/src/jit/JitFrames.cpp is included in vm/Stack.h, which is included almost everywhere.

Comment 5

[Nicolas B. Pierron [:nbp]]

Oh, my mistake. It used to be included indirectly in JitFrameIterator.h for decoding the recover instructions.
As it is only included in cpp files, I no longer see any issues then.

Comment 6

[André Bargull [:anba]]

(In reply to Nicolas B. Pierron [:nbp] from comment #5)
> Oh, my mistake. It used to be included indirectly in JitFrameIterator.h for
> decoding the recover instructions.
> As it is only included in cpp files, I no longer see any issues then.

Great! \o/