1376943 - [Linux] Clicking on photon menu doesn't close it

Status: RESOLVED DUPLICATE of bug 1416271

(Firefox :: Toolbars and Customization, defect, P4)

Description

[James Graham [:jgraham]]

I would expect that clicking on the icon for various photon menus would first open them and then a second click would close them. But it seems like a second click will close and immediately reopen the menu so it just flashes but doesn't go away.

Comment 1

[:Gijs (he/him)]

Sigh, linux. Can't reproduce on Windows or OS X. Maybe it has to do with animations or something. More questions below.

(In reply to James Graham [:jgraham] from comment #0)
> I would expect that clicking on the icon for various photon menus

Can you clarify which exact menus you're seeing this with?

And separately, if you try, say, beta, with a clean profile, do you see the same thing with the hamburger and/or overflow and/or whatever panels/menus you're testing there?

I'm basically not aware we changed anything here, but obviously if we broke something we should fix it. Anyway, your expectations are correct. :-)

Comment 2

[James Graham [:jgraham]]

So this is with the hamburger menu and the (whatever the one in the location bar is called).

And you're right; this seems to be broken in the old menu design too… apparently I didn't notice that for years but did notie this a few weeks ago on the first day I used the new design. Which I can't explain, but now it's really annoying (of course :)

Comment 3

[:Gijs (he/him)]

OK, so if this is not a regression I don't think fixing it needs to be in the minimal set of bugs for shipping, but hopefully we can still get round to investigating and fixing this. I suspect it's potentially related to bug 1375872 and when we add/remove the open style / detect whether the panel has closed etc.

Comment 4

[u554753]

Hi James,

I can't seem to reproduce this issue with the menu in the location bar or with the hamburger menu. Can you tell me which options in the menu are causing the panels to stay open?

For what it's worth, I'm testing on the following user agent:
Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 5

[Dão Gottwald [:dao]]

I can't reproduce this with the latest Nightly on Ubuntu 17.04.

Comment 6

[James Graham [:jgraham]]

Attachment: menu.webm

Hopefully the attached video shows what I'm doing. This is latest nightly on Ubuntu 17.04.

Comment 7

[:Gijs (he/him)]

This looks like it's an older and more-specific bug than bug 1416271, but effectively a dupe. That bug has some more details already and is in what I suspect is the right component - would you agree it makes sense to dupe this over to bug 1416271, or is there some difference I'm missing?

Comment 8

[James Graham [:jgraham]]

Sure.