Open
Bug 1376945
Opened 7 years ago
Updated 7 years ago
Generate Screen Shots for 32 new locales
Categories
(Focus-iOS :: General, enhancement)
Tracking
(Not tracked)
NEW
People
(Reporter: sdaswani, Unassigned)
References
Details
see screenshots.sh in the focus top level directory.
Comment 1•7 years ago
|
||
Bryan: any news about this please? Just a friendly reminder that we can't sign-off on any new locales for 3.4 until we can have these. thanks!
Flags: needinfo?(bmunar)
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #1) > Bryan: any news about this please? Just a friendly reminder that we can't > sign-off on any new locales for 3.4 until we can have these. thanks! Sorry for the delay Delphine - this is Bryan's second highest priority, so he should be able to provide an update soon.
Comment 4•7 years ago
|
||
Bryan/Susheel, I've added a PR to Bug 1379873 to update the telemetry library to resolve the issue getting screenshots for certain locales. We may actually want to push this out in a dot-release since some locales may exhibit this issue in production.
Comment 5•7 years ago
|
||
Just to make sure, I'm literally just running the script right now -- can I confirm what these 32 locales are?
Flags: needinfo?(lebedel.delphine)
Comment 6•7 years ago
|
||
Basically all locales there except Arabic, Azerbaijani, Czech, Welsh, German, English (United States), Esperanto, Spanish from Chile, Spanish from Spain, French, Hungarian, Indonesian, Italian, Japanese, Kabyle, Dutch, Polish, Portuguese (Brazil), Russian, Songhay, Slovak, Slovenian, Swedish, Turkish, Ukrainian, Simplified Chinese and Traditional Chinese. Thanks!
Flags: needinfo?(lebedel.delphine)
Comment 7•7 years ago
|
||
Bryan: was that helpful or did you need the information in another format? Just LMK :)
Flags: needinfo?(bmunar)
Comment 8•7 years ago
|
||
It'd be great to get a list of the locales you need (specified by their code???) because what's happening right now is the screenshot script is taking super super long to print out the screenshots. It's taking hours on end to even complete screenshots for a single device. It's working well I just think it would be more effective if we cut the time in half instead of letting it run for all 60+ locales in the script.
Flags: needinfo?(bmunar)
Comment 9•7 years ago
|
||
Locale code for new locales: af, bn, br, ca, dsb, el, es-MX, eu, fa, ga-IE, gd, he, hi-IN, hsb, is, kk, kn (not 100% complete but adding for QA purposes), ko, lo, ms, my, nb-NO, ne-NP (not 100% complete but adding for QA purposes), nn-NO, pt-PT, ro, sq, ta, te, th, tl, ur, uz
Comment 10•7 years ago
|
||
Hey any updates about this please? do you need any more info? (also, no clue when this release supposed to come out)
Flags: needinfo?(bmunar)
Reporter | ||
Comment 11•7 years ago
|
||
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #10) > Hey any updates about this please? do you need any more info? (also, no clue > when this release supposed to come out) Bryan is still working on the screenshots but there is no huge rush as we have a host of work to do for 3.4: https://github.com/mozilla-mobile/focus-ios/projects/1
Flags: needinfo?(bmunar)
Comment 12•7 years ago
|
||
Ok good to know :) thanks for the update Susheel!
Comment 13•7 years ago
|
||
Screenshots for iPhone7Plus: https://drive.google.com/drive/folders/0BwM0URyvbEeSQmZPVGdiWVlfNm8 Screenshots iPhones7Plus Klar: https://drive.google.com/drive/folders/0BwM0URyvbEeSeEpRWHQ5dFdWd00 (don't pay attention to all the locales there, this should be less soon) We're waiting on screenshots for iPhone5 now. I will have localizers test this in the meantime! thanks everyone
Reporter | ||
Comment 14•7 years ago
|
||
Great to see we can make progress while we get the iPhone5 screenshots working - thanks Delphine & Bryan. Bryan and I hope to figure out the iPhone5 screens issue soon.
You need to log in
before you can comment on or make changes to this bug.
Description
•