1376956 - clang returned by `llvm-config --bindir` needs a .exe on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

.mozbuild/clang/bin/clang returned by `llvm-config --bindir` does not exist.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use `find_program` to search for clang for bindgen configuration

llvm-config on Windows can return a path for the clang binary which does
not end in ".exe", which then causes failures when attempting to check
for the existence of the file.  Rather than attempting to simply tack
".exe" onto the file if it's not already there, delegate to
moz.configure's `find_program` function, which will take care of that
case and several others besides.

I think this should fix things, though I have not run configure on my
machine to check.

Comment 2

[(Away)]

Comment on attachment 8881990 [details] [diff] [review]
use `find_program` to search for clang for bindgen configuration

Fixes the error for me locally

Comment 3

[(Away)]

Although... are you sure you want to do a search in the --with-clang-path case? Seems like, if we don't find the exact thing that was passed, it's the user's problem?

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to David Major [:dmajor] from comment #3)
> Although... are you sure you want to do a search in the --with-clang-path
> case? Seems like, if we don't find the exact thing that was passed, it's the
> user's problem?

We should try to verify that whatever the user passed exists at the earliest possible opportunity.  So we should check in configure, rather than erroring when we try to run something much later in the build.  Searching *should* be OK here, since we have an absolute path, and find_program will simply try tacking on various extensions.

Comment 5

[(Away)]

I guess in general my thought process is, if I go to the trouble of specifying my own path, I'd want either that exact thing to be used, or be given an error -- I wouldn't want the system to go and use some other thing. But if tacking on extensions is all that find_program does, I don't really care that much. :)

Comment 6

[Nathan Froyd [:froydnj]]

(In reply to David Major [:dmajor] from comment #5)
> I guess in general my thought process is, if I go to the trouble of
> specifying my own path, I'd want either that exact thing to be used, or be
> given an error -- I wouldn't want the system to go and use some other thing.
> But if tacking on extensions is all that find_program does, I don't really
> care that much. :)

That's fair.  I guess it depends whether we expect people to do:

  --with-clang-path=clang

or:

  --with-clang-path=C:/path/to/clang

and even in the latter case, I think it would be friendly to try extensions.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e4b627fa622
use `find_program` to search for clang for bindgen configuration; r=rillian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e4b627fa622