Closed
Bug 1376959
Opened 8 years ago
Closed 8 years ago
Unified fuzzing interface doesn't build with AFL (missing LibFuzzerRegistry.h)
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: decoder, Assigned: decoder)
References
Details
Attachments
(1 file)
In tools/fuzzing/interface/FuzzingInterface.h we're missing the include for LibFuzzerRegistry.h although we use the registry in that file. This caused the SDP fuzzer from WebRTC to not work initially. Nils added the header to his SDP fuzzer in media/webrtc/signaling/fuzztest/sdp_parser_libfuzz.cpp but without an ifdef around it for LibFuzzer. As a result, the build now fails when building with AFL because this header file is not available in AFL builds. The right location for the include is in FuzzingInterface.h and it should be guarded with an ifdef, easy patch coming up :)
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881980 [details]
Bug 1376959 - Fix broken/missing LibFuzzerRegistry.h include.
https://reviewboard.mozilla.org/r/153046/#review158284
Attachment #8881980 -
Flags: review?(nfroyd) → review+
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/916d5c0dbea2
Fix broken/missing LibFuzzerRegistry.h include. r=froydnj
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•