Closed Bug 1376960 Opened 7 years ago Closed 6 years ago

Set prefs to automate gUM-prompts for WPT

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(2 files)

Bug 1376960 - Use prefs for automated gUM prompts in WPT.
59 bytes, text/x-review-board-request
jib
: review+
Details
Bug 1376960 - Update WPT expectations for mediacapture-streams.
59 bytes, text/x-review-board-request
jib
: review+
Details 
WPT has a couple of tests for gUM that requires manual intervention to approve or reject the gUM prompt. We have prefs for doing this automatically that would make these tests pass in automation.
Attachment #8882056 - Flags: review?(jib)
Comment on attachment 8882056 [details]
Bug 1376960 - Use prefs for automated gUM prompts in WPT.

https://reviewboard.mozilla.org/r/153136/#review158668

::: testing/web-platform/meta/mediacapture-streams/GUM-impossible-constraint.https.html.ini:2
(Diff revision 1)
>  [GUM-impossible-constraint.https.html]
> +  prefs: [media.navigator.permission.disabled:true]

We should add

    media.navigator.streams.fake:true

as well to use fake devices.
Attachment #8882056 - Flags: review?(jib) → review+
Rank: 15
Priority: -- → P1
Is landing this blocking on upstream review of https://github.com/w3c/web-platform-tests/pull/6429 ?
Flags: needinfo?(apehrson)
Btw, it looks like we need fake-device enabling for our webrtc WPT tests as well. See bug 1393211 comment 8.
Right, I'll get to it a bit sooner then. I don't think I'm strictly blocked on that landing. It's more the convenience of testing all the bits together.
Flags: needinfo?(apehrson)
Mass change P1->P2 to align with new Mozilla triage process
Priority: P1 → P2
Comment on attachment 8960551 [details]
Bug 1376960 - Update WPT expectations for mediacapture-streams.

https://reviewboard.mozilla.org/r/229262/#review240380

Lgtm.
Attachment #8960551 - Flags: review?(jib) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6709d1d42004b38d5d42ba0c752837e20110545b -d eebb8d4e91d1: rebasing 456799:6709d1d42004 "Bug 1376960 - Use prefs for automated gUM prompts in WPT. r=jib"
rebasing 456800:d467363e6885 "Bug 1376960 - Update WPT expectations for mediacapture-streams. r=jib" (tip)
merging testing/web-platform/meta/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html.ini
merging testing/web-platform/meta/mediacapture-streams/MediaStreamTrack-idl.https.html.ini
warning: conflicts while merging testing/web-platform/meta/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html.ini! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/web-platform/meta/mediacapture-streams/MediaStreamTrack-idl.https.html.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b7fbecf2c5fc
Use prefs for automated gUM prompts in WPT. r=jib
https://hg.mozilla.org/integration/autoland/rev/bd3dba2ce939
Update WPT expectations for mediacapture-streams. r=jib
https://hg.mozilla.org/mozilla-central/rev/b7fbecf2c5fc
https://hg.mozilla.org/mozilla-central/rev/bd3dba2ce939
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: