1376962 - [Fennec] Fix defects in ​GeckoMediaDrmBridgeV21

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

See defects from https://scan4.coverity.com/reports.htm#v27812/p11134/fileInstanceId=21856797

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1376962 - Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21

Review commit: https://reviewboard.mozilla.org/r/153420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153420/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8882345 [details]
Bug 1376962 - Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21

https://reviewboard.mozilla.org/r/153420/#review158624

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoMediaDrmBridgeV21.java:654
(Diff revision 1)
>      private UUID convertKeySystemToSchemeUUID(String keySystem) {
>        if (WIDEVINE_KEY_SYSTEM.equals(keySystem)) {
>            return WIDEVINE_SCHEME_UUID;
>        }
>        if (DEBUG) Log.d(LOGTAG, "Cannot convert unsupported key system : " + keySystem);
> -      return null;
> +      return new UUID(0, 0);

According to the prototype https://developer.android.com/reference/java/util/UUID.html#UUID(long, long)

Please write 0L, 0L instead of 0 for getting rid of the warning of some static analysis tool.

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8882345 [details]
Bug 1376962 - Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153420/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/179df3689ff6
Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21 r=JamesCheng

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/179df3689ff6