Closed
Bug 1376962
Opened 8 years ago
Closed 8 years ago
[Fennec] Fix defects in GeckoMediaDrmBridgeV21
Categories
(Firefox for Android Graveyard :: Audio/Video, enhancement, P3)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kikuo, Assigned: kikuo)
Details
Attachments
(1 file)
Updated•8 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → kikuo
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8882345 [details]
Bug 1376962 - Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21
https://reviewboard.mozilla.org/r/153420/#review158624
::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoMediaDrmBridgeV21.java:654
(Diff revision 1)
> private UUID convertKeySystemToSchemeUUID(String keySystem) {
> if (WIDEVINE_KEY_SYSTEM.equals(keySystem)) {
> return WIDEVINE_SCHEME_UUID;
> }
> if (DEBUG) Log.d(LOGTAG, "Cannot convert unsupported key system : " + keySystem);
> - return null;
> + return new UUID(0, 0);
According to the prototype https://developer.android.com/reference/java/util/UUID.html#UUID(long, long)
Please write 0L, 0L instead of 0 for getting rid of the warning of some static analysis tool.
Attachment #8882345 -
Flags: review?(jacheng) → review+
Comment hidden (mozreview-request) |
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/179df3689ff6
Fix defects found from Coverity Scan for GeckoMediaDrmBridgeV21 r=JamesCheng
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•