Closed Bug 1376968 Opened 2 years ago Closed 2 years ago

remove -fsanitize=edge from fuzzing mozconfig.

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: rforbes, Assigned: rforbes)

References

Details

Attachments

(2 files)

this flag is not compatible with the version of libfuzzer we are using.
We will use -fsanitize-coverage=trace-pc instead but that shouldn't be added to the mozconfig. Instead, we should enable this flag on an as-needed basis in sub directories that actually implement anything using the unified fuzzing interface. The reason for this is that any additional code that is instrumented with this causes libfuzzer to run slower. I made benchmarks with kcc that showed a 60-70% slowdown on the sdp fuzzing target with all of the codebase compiled with trace-pc.
Attachment #8881996 - Flags: review?(choller)
Comment on attachment 8881996 [details]
BUG 1376968 - remove fsantize edge flag

https://reviewboard.mozilla.org/r/153074/#review159720

r+. fuzzing-only.
Attachment #8881996 - Flags: review?(choller) → review+
Comment on attachment 8883730 [details]
Bug 1376968 - Remove obsolete -fsantize-coverage=edge from fuzzing config.

https://reviewboard.mozilla.org/r/154636/#review159728

Setting r+ again for changed commit message. For the record: I only fixed typos and style issues with the commit message here so we can land this.
Attachment #8883730 - Flags: review?(choller) → review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 7132e300ef0d needs "Bug N" or "No bug" in the commit message.
remote: rforbes <rforbes@mozilla.com>
remote: Buh 1376968 - Remove obsolete -fsantize-coverage=edge from fuzzing config. r=decoder
remote: 
remote: MozReview-Commit-ID: IJAoxu9Ovze
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Comment on attachment 8883730 [details]
Bug 1376968 - Remove obsolete -fsantize-coverage=edge from fuzzing config.

https://reviewboard.mozilla.org/r/154636/#review159732

r+ now with 100% less typos even >.<
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8873830c2c94
Remove obsolete -fsantize-coverage=edge from fuzzing config. r=decoder
Thanks for improving the build time on this linux64 config:

== Change summary for alert #7711 (as of July 05 2017 22:12 UTC) ==

Improvements:

 14%  build times summary linux64 asan asan-fuzzing taskcluster-c4.4xlarge     1,289.68 -> 1,107.82

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7711
https://hg.mozilla.org/mozilla-central/rev/8873830c2c94
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox Build System
Assignee: nobody → rforbes
You need to log in before you can comment on or make changes to this bug.