1376982 - Missing "action" GET parameter from an FxA deep link

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Grisha Kruglov]

We need to have "action=signin" as a parameter in the deep link FxA which we open - otherwise sign-up page is displayed by default, instead of the sign-in page.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1376982 - Add "action" parameter to the adjust deep link

We need to open the accounts page directly to the sign-in page, instead of the default sign-up page

Review commit: https://reviewboard.mozilla.org/r/153092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153092/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8882007 [details]
Bug 1376982  - Add "action" parameter to the adjust deep link

https://reviewboard.mozilla.org/r/153092/#review158424

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67761f5802a4
Add "action" parameter to the adjust deep link r=nechen

Comment 4

[:Grisha Kruglov]

Attachment: deep-linking-beta.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1356386

[User impact if declined]: Wrong about:accounts page is opened during FxA deep-link sign-in flow. This _could_ be solved on the fxa-content-server side, but the client-side adjustment is trivial.

[Is this code covered by automated tests?]: No.

[Has the fix been verified in Nightly?]: Just landed on m-c, waiting for the patch to make it to nightly.

[Needs manual test from QE? If yes, steps to reproduce]: Opening an FxA deep link must take the user to a FxA sign-in page, as opposed to sign-up page.
STR:
- with the Firefox which includes this patch installed on the device, open first URL from https://thimbleprojects.org/grigoryk/251895/ - specifically, firefox://fxa-signin?signin=test-token - in Chrome
- expect to see Firefox open on the about:accounts sign-in page.

[List of other uplifts needed for the feature/fix]: N/a

[Is the change risky?]: No

[Why is the change risky/not risky?]: A very trivial adjustment to a URL while processing an intent.

[String changes made/needed]: n/a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67761f5802a4

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8882188 [details] [diff] [review]
deep-linking-beta.patch

fxa link fix for fennec, beta55+

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f9678179979d

Comment 8

[Andrei Vaida [:avaida]]

(In reply to :Grisha Kruglov from comment #4)
> [Is this code covered by automated tests?]: No.
> 
> [Has the fix been verified in Nightly?]: Just landed on m-c, waiting for the
> patch to make it to nightly.
> 
> [Needs manual test from QE? If yes, steps to reproduce]: Opening an FxA deep
> link must take the user to a FxA sign-in page, as opposed to sign-up page.
> STR:
> - with the Firefox which includes this patch installed on the device, open
> first URL from https://thimbleprojects.org/grigoryk/251895/ - specifically,
> firefox://fxa-signin?signin=test-token - in Chrome
> - expect to see Firefox open on the about:accounts sign-in page.

Flagging this for manual testing.

Comment 9

[Oana Horvath [:ohorvath]]

Verified as fixed on Beta 55.0b7 (2017-07-07), based on STR in Comment 4.
Devices:
-Samsung Galaxy Note 4 (Android 5.0.1)
-HTC Nexus 9 (Android 7.1.1)

Comment 10

[Stefan Deiac]

I will remove the qe-verify flag based on comment 9.