1377015 - Implement MediaCodecs::ContainsPrefix

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Ralph Giles (:rillian)]

Many video codecs use a suffix to specify level, profile and optional features, like avc1.42E001 or vp09.00.41.08. To facilitate codec identification it would be nice to have some kind of prefix-matching version of the Contains() method.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1377015 - MediaCodecs::ContainsPrefix implementation and tests -

Review commit: https://reviewboard.mozilla.org/r/153336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153336/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8882249 [details]
Bug 1377015 - MediaCodecs::ContainsPrefix implementation and tests -

https://reviewboard.mozilla.org/r/153336/#review158558

::: commit-message-f3483:2
(Diff revision 1)
> +Bug 1377015 - MediaCodecs::ContainsPrefix implementation and tests - r?rillian
> +

In the spirit of better commit messages, please offer some motivation in the body of the patch. Why did we want to make this change?

::: dom/media/gtest/TestMediaMIMETypes.cpp:252
(Diff revision 1)
>    EXPECT_TRUE(type->Codecs().Contains(NS_LITERAL_STRING("a")));
>    EXPECT_TRUE(type->Codecs().Contains(NS_LITERAL_STRING("b")));
> +  EXPECT_TRUE(type->Codecs().ContainsPrefix(NS_LITERAL_STRING("a")));
> +  EXPECT_TRUE(type->Codecs().ContainsPrefix(NS_LITERAL_STRING("b")));
> +  EXPECT_FALSE(type->Codecs().ContainsPrefix(NS_LITERAL_STRING("ab")));
> +  EXPECT_FALSE(type->Codecs().ContainsPrefix(NS_LITERAL_STRING("ba")));

`EXPECT_FALSE(type->Codecs().ContainsPrefix(NS_LITERAL_STRING("a,b")));` maybe?

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8882249 [details]
Bug 1377015 - MediaCodecs::ContainsPrefix implementation and tests -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153336/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4ecac52eceb
MediaCodecs::ContainsPrefix implementation and tests - r=rillian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f4ecac52eceb