1377020 - Remove sentinel enumerators in gfx/layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Botond Ballo [:botond]]

Once bug 1371771 is in place, we can remove sentinel enumerators by using MOZ_DEFINE_ENUM or one of its variants to define the affected enumerations instead.

I'm going to do that for enumerations defined in gfx/layers in this bug.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1377020 - Use MOZ_DEFINE_ENUM instead of a sentinel enumerator for enumerations in gfx/layers.

Review commit: https://reviewboard.mozilla.org/r/153146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153146/

Comment 2

[Botond Ballo [:botond]]

I'm posting this for reference, but not for review yet, in case interface changes are made during the review of bug 1371771.

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8882059 [details]
Bug 1377020 - Use MOZ_DEFINE_ENUM instead of a sentinel enumerator for enumerations in gfx/layers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153146/diff/1-2/

Comment 4

[Botond Ballo [:botond]]

I realized that this patch doesn't work as written. It changes the argument passed for the |HighBound| template parameter of ContiguousEnumSerializer from the sentinel value to the highest legal value, but ContiguousEnumSerializer expects |HighBound| to be a sentinel value (it checks that actual values are strictly less than it).

I think that eventually we'll want to change ContiguousEnumSerializer to interpret |HighBound| as the highest legal value. However, I'd prefer not to transition all of the enums that use ContiguousEnumSerializer at once, so I think for now I'll introduce a ContiguousEnumSerializerInclusive variant.

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8882059 [details]
Bug 1377020 - Use MOZ_DEFINE_ENUM instead of a sentinel enumerator for enumerations in gfx/layers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153146/diff/2-3/

Comment 6

[Botond Ballo [:botond]]

Whoops, MozReview fail. There should be a second patch here.

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1377020 - Add a new enum serializer ContiguousEnumSerializerInclusive.

This allows specifying the highest legal value rather than a sentinel
value, to support enumerations that don't have a sentinel.

Review commit: https://reviewboard.mozilla.org/r/154616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154616/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8883706 [details]
Bug 1377020 - Add a new enum serializer ContiguousEnumSerializerInclusive.

https://reviewboard.mozilla.org/r/154616/#review159704

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8882059 [details]
Bug 1377020 - Use MOZ_DEFINE_ENUM instead of a sentinel enumerator for enumerations in gfx/layers.

https://reviewboard.mozilla.org/r/153146/#review159706

Woohoo!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6641837cae96
Add a new enum serializer ContiguousEnumSerializerInclusive. r=kats
https://hg.mozilla.org/integration/autoland/rev/484dcb23bd4d
Use MOZ_DEFINE_ENUM instead of a sentinel enumerator for enumerations in gfx/layers. r=kats

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6641837cae96
https://hg.mozilla.org/mozilla-central/rev/484dcb23bd4d