1377049 - Add pre-push and pre-commit version control hooks

Status: RESOLVED DUPLICATE of bug 1361972

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Andrew Halberstadt [:ahal]]

There are currently some hooks for eslint hanging around the tree. But it would be nice if there were generic mozlint hooks that ran all the linters. I'd also like to provide some pre-push hooks as an alternative to pre-commit.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1377049 - Add a pre-push and pre-commit mozlint hooks

This adds pre-push and pre-commit hooks for both hg and git. All
four possibilities are implemented in the same file.

To enable a pre-push hg hook, add the following to hgrc:

    [hooks]
    pre-push.lint = python:/path/to/gecko/tools/lint/hooks.py:hg


To enable a pre-commit hg hook, add the following to hgrc:

    [hooks]
    pretxncommit.lint = python:/path/to/gecko/tools/lint/hooks.py:hg


To enable a pre-push git hook, run the following command:

    $ ln -s /path/to/gecko/tools/lint/hooks.py .git/hooks/pre-push


To enable a pre-commit git hook, run the following command:

    $ ln -s /path/to/gecko/tools/lint/hooks.py .git/hooks/pre-commit

Review commit: https://reviewboard.mozilla.org/r/153180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153180/

Comment 2

[Andrew Halberstadt [:ahal]]

This patch obsoletes the eslintvalidate hooks, though if we want to remove them we'll need some kind of error message that includes the upgrade path.

Also by design, ./mach lint --workdir lints both staged and unstaged files in git. Maybe it needs some kind of mode that only lints the staged files?

I also haven't really tested the pre-push git hook as I don't feel like setting up cinnabar on my laptop. I'll do some testing when I get back from the work week (though it looks like it should work).