Unify gfxMatrix with gfx::Matrix

RESOLVED FIXED in Firefox 56

Status

()

Core
Graphics
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

Following up from bug 1376782, we can unify gfxMatrix with gfx::Matrix, and reduce gfxMatrix to a lowly typedef.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Blocks: 1377169

Comment 6

a year ago
mozreview-review
Comment on attachment 8882137 [details]
Bug 1377090 - Make the Matrix class templated so we can instantiate it with a double type.

https://reviewboard.mozilla.org/r/153252/#review158838
Attachment #8882137 - Flags: review?(bas) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8882138 [details]
Bug 1377090 - Move NudgeToInteger(double) into Tools.h for reuse.

https://reviewboard.mozilla.org/r/153254/#review158842

::: gfx/thebes/gfxMatrix.cpp:146
(Diff revision 1)
> -}
> -
>  gfxMatrix&
>  gfxMatrix::NudgeToIntegers(void)
>  {
> -    NudgeToInteger(&_11);
> +    mozilla::gfx::NudgeToInteger(&_11);

nit: Since is a cpp file can we just do using namespace mozilla::gfx;?
Attachment #8882138 - Flags: review?(bas) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8882139 [details]
Bug 1377090 - Further generify the Matrix class and define MatrixDouble.

https://reviewboard.mozilla.org/r/153256/#review158844
Attachment #8882139 - Flags: review?(bas) → review+
(Assignee)

Comment 9

a year ago
mozreview-review-reply
Comment on attachment 8882138 [details]
Bug 1377090 - Move NudgeToInteger(double) into Tools.h for reuse.

https://reviewboard.mozilla.org/r/153254/#review158842

> nit: Since is a cpp file can we just do using namespace mozilla::gfx;?

We could, but this file gets deleted in part 4 anyway so there's not much point.

Comment 11

a year ago
mozreview-review
Comment on attachment 8882140 [details]
Bug 1377090 - Turn gfxMatrix into a typedef for MatrixDouble.

https://reviewboard.mozilla.org/r/153258/#review159590
Attachment #8882140 - Flags: review?(jmuizelaar) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 16

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aecdc7b7c830
Make the Matrix class templated so we can instantiate it with a double type. r=bas
https://hg.mozilla.org/integration/autoland/rev/e6f68aad8e3d
Move NudgeToInteger(double) into Tools.h for reuse. r=bas
https://hg.mozilla.org/integration/autoland/rev/5468507e9a0a
Further generify the Matrix class and define MatrixDouble. r=bas
https://hg.mozilla.org/integration/autoland/rev/e21a77cab740
Turn gfxMatrix into a typedef for MatrixDouble. r=jrmuizel

Comment 17

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aecdc7b7c830
https://hg.mozilla.org/mozilla-central/rev/e6f68aad8e3d
https://hg.mozilla.org/mozilla-central/rev/5468507e9a0a
https://hg.mozilla.org/mozilla-central/rev/e21a77cab740
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.