Closed Bug 1377118 Opened 7 years ago Closed 7 years ago

Update in-tree libpng to version 1.6.31

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

Details

Attachments

(2 files, 4 obsolete files)

v01-1377118-libpng-1.6.31-part2
951 bytes, patch
Details | Diff | Splinter Review
v03-1377118-libpng-1.6.31
139.76 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
libpng-1.6.30 has been released.  There's no urgent reason to update, but I will provide a patch.
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Attached patch v00-1377118-libpng-1.6.30 (obsolete) — — Splinter Review 
Please submit to try.
Flags: needinfo?(ryanvm)
Try looks pretty good so far except that the Android 4.0 builds failed for some reason, while trying to compile arm/filter_neon.S. The other Android builds succeeded, but they seem to not use the arm code.
Attached patch v01-1377118-libpng-1.6.30 (obsolete) — — Splinter Review 
Work around android 4.0 build failure.  Please "try"
Attachment #8882552 - Attachment is obsolete: true
Flags: needinfo?(ryanvm)
Attached patch v02-1377118-libpng-1.6.30 (obsolete) — — Splinter Review 
Merge pngpriv.h patch with libpng-1.6.31beta01
Attachment #8882770 - Attachment is obsolete: true
Attached patch v00-1377118-libpng-1.6.30-part2 (obsolete) — — Splinter Review 
Update MOZPNG to 10630 in old-configure.in
The Android 4.0 builds look OK now.  I've released libpng-1.6.31beta01 with the same patch as tried here.  I expect that libpng-1.6.31 will be out in about 2 weeks; we might as well skip 1.6.30 for now.
Summary: Update in-tree libpng to version 1.6.30 → Update in-tree libpng to version 1.6.31

        Attachment #8882872 -
        Attachment is obsolete: true

    
    

    
  


  
Please submit to try along with part2.

        Attachment #8882871 -
        Attachment is obsolete: true
Flags: needinfo?(ryanvm)

    
    

    
  
Comment on attachment 8891022 [details] [diff] [review]
v03-1377118-libpng-1.6.31

"try" looks OK except for Windows 8 and XP that don't appear to be related to this libpng upgrade.

        Attachment #8891022 -
        Flags: review?(jmuizelaar)

        Attachment #8891022 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16cb5a4806b6
Update in-tree libpng to version 1.6.31. r=jrmuizel

    
  

        Attachment #8891021 -
        Flags: checkin?

    
  

        Attachment #8891022 -
        Flags: checkin?

        Attachment #8891022 -
        Flags: checkin?

    
    

    
  
Comment on attachment 8891021 [details] [diff] [review]
v01-1377118-libpng-1.6.31-part2

I folded this into the other patch.

        Attachment #8891021 -
        Flags: checkin?

    
    

    
  
OK, thanks.  I had put it into a separate "part2" because old-configure.in changes rot pretty quickly.

    
  
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

          status-firefox56:
          --- → fixed
Target Milestone: --- → mozilla56

    
  
Blocks: 1402057

    
  
Blocks: 1402140

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: