nsRefreshDriver::AddImageRequest does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
(also removing an unnecessary null-check from the infallible PutEntry
in the then-branch)
Attachment #8882181 - Flags: review?(nfroyd)
Attachment #8882181 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 2

2 years ago
I see I mistakenly added a "[delay]" capture there which I don't use.
I'll remove that before landing...

Comment 3

2 years ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccd25299f03f
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups in nsRefreshDriver::AddImageRequest.  r=froydnj

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ccd25299f03f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.