Closed
Bug 1377163
Opened 7 years ago
Closed 7 years ago
Remove search result from category list
Categories
(Firefox :: Settings UI, enhancement, P1)
Tracking
()
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | verified |
People
(Reporter: rickychien, Assigned: evanxd)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-preference])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
mconley
:
review+
Tina_Hsieh
:
ui-review+
|
Details |
Remove search result icon & title from category list when user performs a search.
Updated•7 years ago
|
Flags: qe-verify+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → evan
Priority: P2 → P1
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Target Milestone: Firefox 57 → Firefox 56
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8888669 -
Flags: review?(mconley)
Assignee | ||
Comment 2•7 years ago
|
||
Hi Mike, Could you review the patch? Thank you.
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8888669 [details] Bug 1377163 - Remove search result from the category list. Hi Tina, Could you review the UI change? Thank you.
Attachment #8888669 -
Flags: ui-review?(thsieh)
Comment 4•7 years ago
|
||
Comment on attachment 8888669 [details] Bug 1377163 - Remove search result from the category list. It worked as what I described on the updated spec: https://mozilla.invisionapp.com/share/ZDAGPK3AF#/218928267_5-1_Type Thanks for the patch!
Attachment #8888669 -
Flags: ui-review?(thsieh) → ui-review+
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8888669 [details] Bug 1377163 - Remove search result from the category list. https://reviewboard.mozilla.org/r/159698/#review165808 Thanks! ::: browser/themes/shared/incontentprefs/preferences.inc.css (Diff revision 2) > -#category-advanced > .category-icon { > - list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#advanced"); > -} > - > -#category-search-results > .category-icon { > - list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#searchResults"); > -} > - I guess this is just unrelated clean-up? Or is this from some other patch accidentally?
Attachment #8888669 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 7•7 years ago
|
||
> I guess this is just unrelated clean-up? Or is this from some other patch
> accidentally?
Yes, that is a clean-up.
Assignee | ||
Comment 8•7 years ago
|
||
The try[1] looks good. Let's land the patch. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be32e18673f3&selectedJob=117289612
Keywords: checkin-needed
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a43e1437ab6 Remove search result from the category list. r=mconley
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6a43e1437ab6
Comment 11•7 years ago
|
||
Build ID: 20170726030207 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•