Closed Bug 1377163 Opened 3 years ago Closed 3 years ago

Remove search result from category list

Categories

(Firefox :: Preferences, enhancement, P1)

55 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified

People

(Reporter: rickychien, Assigned: evanxd)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Remove search result icon & title from category list when user performs a search.
Flags: qe-verify+
Assignee: nobody → evan
Priority: P2 → P1
Status: NEW → ASSIGNED
Blocks: 1357285
No longer blocks: 1357306
Target Milestone: Firefox 57 → Firefox 56
Attachment #8888669 - Flags: review?(mconley)
Hi Mike,

Could you review the patch?

Thank you.
Comment on attachment 8888669 [details]
Bug 1377163 - Remove search result from the category list.

Hi Tina,

Could you review the UI change?

Thank you.
Attachment #8888669 - Flags: ui-review?(thsieh)
Comment on attachment 8888669 [details]
Bug 1377163 - Remove search result from the category list.

It worked as what I described on the updated spec: https://mozilla.invisionapp.com/share/ZDAGPK3AF#/218928267_5-1_Type

Thanks for the patch!
Attachment #8888669 - Flags: ui-review?(thsieh) → ui-review+
Comment on attachment 8888669 [details]
Bug 1377163 - Remove search result from the category list.

https://reviewboard.mozilla.org/r/159698/#review165808

Thanks!

::: browser/themes/shared/incontentprefs/preferences.inc.css
(Diff revision 2)
> -#category-advanced > .category-icon {
> -  list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#advanced");
> -}
> -
> -#category-search-results > .category-icon {
> -  list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#searchResults");
> -}
> -

I guess this is just unrelated clean-up? Or is this from some other patch accidentally?
Attachment #8888669 - Flags: review?(mconley) → review+
> I guess this is just unrelated clean-up? Or is this from some other patch
> accidentally?

Yes, that is a clean-up.
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a43e1437ab6
Remove search result from the category list. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6a43e1437ab6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Build ID: 20170726030207
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.