Closed Bug 1377193 Opened 7 years ago Closed 7 years ago

[Fennec][HLS][Test] Add a simple HLS test case and test resource into dom/media/test for further test case usage

Categories

(Firefox for Android Graveyard :: Audio/Video, enhancement, P3)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

Details

Attachments

(1 file)

We want to add some test cases about HLS but currently we need to add some resources like master playlist m3u8, media playlist m3u8 and its corresponding TS chunks with different quality.

Let's do it in this bug.
Hi JW,

Please help us to review this patch.

This is our first step for our HLS test case which put the HLS content into source tree and a simple test case.

We will start to write more testing about HLS based on this.

Thank you.
Assignee: nobody → jacheng
Comment on attachment 8882266 [details]
Bug 1377193 - Add the m3u8 and media contents into gecko and add one general test case run only on Fennec for testing HLS.

https://reviewboard.mozilla.org/r/153380/#review159062

::: dom/media/test/manifest.js:29
(Diff revision 2)
>  
> +// Need to get the server url composed with ip:port instead of mochi.test.
> +// Since we will provide the url to Exoplayer which cannot recognize the domain
> +// name "mochi.test".
> +let serverUrl = SpecialPowers.Services.prefs.getCharPref("media.hls.server.url");
> +var gHLSTests = [

Can you just append this list to gPlayTests so we can resue test_playback.html?
Priority: -- → P3
Hi JW, 
The main reason that I isolated the test case from gPlayTests is because

test_playback.html

(http://searchfox.org/mozilla-central/rev/e8f4f51cd543f203e9cb861cecb7545ac43c836c/dom/media/test/mochitest.ini#954-955)

is skipped on Android and the test_playback.html listened to the 'suspend' event that we didn't need to test this on HLS case.

If test_playback.html is enabled in the future, I will consider merge the test resource instead of isolate them.

Thanks.
Flags: needinfo?(jwwang)
Comment on attachment 8882266 [details]
Bug 1377193 - Add the m3u8 and media contents into gecko and add one general test case run only on Fennec for testing HLS.

https://reviewboard.mozilla.org/r/153380/#review159420

Fair enough. Please add a todo item so we remember to remove the duplicate code in the future.
Attachment #8882266 - Flags: review?(jwwang) → review+
Flags: needinfo?(jwwang)
Comment on attachment 8882266 [details]
Bug 1377193 - Add the m3u8 and media contents into gecko and add one general test case run only on Fennec for testing HLS.

https://reviewboard.mozilla.org/r/153380/#review159770

::: dom/media/test/hls/high_prog_index.m3u8:7
(Diff revision 2)
> +#EXT-X-TARGETDURATION:10
> +#EXT-X-VERSION:3
> +#EXT-X-MEDIA-SEQUENCE:0
> +#EXT-X-PLAYLIST-TYPE:VOD
> +#EXTINF:9.97667,
> +high0.ts

Is it possible to use resolution as the name of this file  ? e.g. 720x480_seg1.ts, 720x480_seg2.ts ?

I feel like it might cause confustion easily.
Obey.

will update the patches

thanks.
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b01a7a17f3a2
Add the m3u8 and media contents into gecko and add one general test case run only on Fennec for testing HLS. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/b01a7a17f3a2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: