1377215 - Add WebSocketEventService::Get

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, enhancement)

Description

[Andreas Farre [:farre]]

For the cases where we really only need to get ahold of a WebSocketEventService if there is one.

Comment 1

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1377215-Add-WebSocketEventService-Get.-r-mcmanus.patch

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8882297 [details] [diff] [review]
0001-Bug-1377215-Add-WebSocketEventService-Get.-r-mcmanus.patch

Review of attachment 8882297 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/websocket/WebSocketEventService.cpp
@@ +206,5 @@
> +WebSocketEventService::Get()
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  return gWebSocketEventService.forget();

This patch seems to call forget(), which will set gWeb* to null, in a method named get() (which wouldn't normally have a side effect..)

maybe you just want GetOrCreate() ?

Comment 3

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1377215-Add-WebSocketEventService-Get.-r-mcmanus.patch

I really do want ::Get that explicitly doesn't create. I'm going to use Get before calling HasListenerFor, and if the case is that there is no service I don't want to create it since, then there won't be any listeners to begin with but I'll end up with a service that isn't actually used.

So it's just me being stupip, I should've gone through a RefPtr as with GetOrCreate.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/454598683af7
Add WebSocketEventService::Get. r=mcmanus

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/454598683af7