(photon) - Let some toolbar views become theme-able

RESOLVED FIXED in Firefox 56

Status

()

Firefox for Android
General
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: walkingice, Assigned: walkingice)

Tracking

(Blocks: 1 bug)

56 Branch
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

4 months ago
There are some views in Toolbar, such as

* Mic icon
* QRCode icon
* Search icon
* Site identity

In Australis-flavor, they always have same appearance regardless of normal/private mode. However in Photon-flavor, their appearance should changed.

This bug tries to changes their class type from `Foo` to `ThemedFoo`.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

4 months ago
mozreview-review
Comment on attachment 8882383 [details]
Bug 1377294 - Let Site-Identity becomes theme-able

https://reviewboard.mozilla.org/r/153490/#review159258

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java:166
(Diff revision 1)
>          mStop = (ImageButton) findViewById(R.id.stop);
>          mPageActionLayout = (PageActionLayout) findViewById(R.id.page_action_layout);
>      }
>  
>      @Override
> +    public void setPrivateMode(boolean isPrivate) {

Should add `super.setPrivateMode(boolean)`?
Attachment #8882383 - Flags: review?(topwu.tw) → review+

Comment 6

4 months ago
mozreview-review
Comment on attachment 8882384 [details]
Bug 1377294 - ToolbarDisplay layout color span supports Pirvate mode

https://reviewboard.mozilla.org/r/153492/#review159260

::: mobile/android/app/src/australis/res/values/colors.xml:111
(Diff revision 1)
>    <color name="url_bar_urltext">#AFB1B3</color>
>    <color name="url_bar_urltext_private">#777777</color>
>    <color name="url_bar_domaintext">#363B40</color>
>    <color name="url_bar_domaintext_private">#FFFFFF</color>
>    <color name="url_bar_blockedtext">#b14646</color>
> +  <color name="url_bar_blockedtext_private">#b14646</color>

Maybe just reference to `@color/url_bar_blockedtext`?
Attachment #8882384 - Flags: review?(topwu.tw) → review+

Comment 7

4 months ago
mozreview-review
Comment on attachment 8882382 [details]
Bug 1377294 - Let some icon in ToolbarEditLayout become Theme-able

https://reviewboard.mozilla.org/r/153488/#review159262
Attachment #8882382 - Flags: review?(topwu.tw) → review+

Comment 8

4 months ago
mozreview-review
Comment on attachment 8882381 [details]
Bug 1377294 - duplicate xml resource files

https://reviewboard.mozilla.org/r/153486/#review159264
Attachment #8882381 - Flags: review?(topwu.tw) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Keywords: checkin-needed

Comment 13

4 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cf287966c9f
duplicate xml resource files r=jwu
https://hg.mozilla.org/integration/autoland/rev/a2e429b4f101
Let some icon in ToolbarEditLayout become Theme-able r=jwu
https://hg.mozilla.org/integration/autoland/rev/3de22a3d12a9
Let Site-Identity becomes theme-able r=jwu
https://hg.mozilla.org/integration/autoland/rev/8122909722c4
ToolbarDisplay layout color span supports Pirvate mode r=jwu
Keywords: checkin-needed

Comment 14

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2cf287966c9f
https://hg.mozilla.org/mozilla-central/rev/a2e429b4f101
https://hg.mozilla.org/mozilla-central/rev/3de22a3d12a9
https://hg.mozilla.org/mozilla-central/rev/8122909722c4
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 15

4 months ago
mozreview-review
Comment on attachment 8882381 [details]
Bug 1377294 - duplicate xml resource files

https://reviewboard.mozilla.org/r/153486/#review160590
Attachment #8882381 - Flags: review?(cnevinchen) → review+

Comment 16

4 months ago
mozreview-review
Comment on attachment 8882382 [details]
Bug 1377294 - Let some icon in ToolbarEditLayout become Theme-able

https://reviewboard.mozilla.org/r/153488/#review160592
Attachment #8882382 - Flags: review?(cnevinchen) → review+

Comment 17

4 months ago
mozreview-review
Comment on attachment 8882383 [details]
Bug 1377294 - Let Site-Identity becomes theme-able

https://reviewboard.mozilla.org/r/153490/#review160594
Attachment #8882383 - Flags: review?(cnevinchen) → review+

Comment 18

4 months ago
mozreview-review
Comment on attachment 8882384 [details]
Bug 1377294 - ToolbarDisplay layout color span supports Pirvate mode

https://reviewboard.mozilla.org/r/153492/#review160596

LGTM
Attachment #8882384 - Flags: review?(cnevinchen) → review+
Depends on: 1379503
You need to log in before you can comment on or make changes to this bug.