Update the search icon.

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Preferences
P1
normal
VERIFIED FIXED
6 months ago
4 months ago

People

(Reporter: evanxd, Assigned: rickychien)

Tracking

55 Branch
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-preference])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

6 months ago
Since current search icon breaks the layout of Preferences menu. We need to update the search icon.
Flags: qe-verify+
(Reporter)

Comment 1

6 months ago
Hi Helen,

This is the icon file[1]. Could you help update it? Thank you.

[1]: http://searchfox.org/mozilla-central/source/browser/themes/shared/incontentprefs/icons.svg
Flags: needinfo?(hhuang)

Comment 2

5 months ago
Created attachment 8884738 [details]
icons.svg

Updated the search icon to the source file, let me know if any questions!
Flags: needinfo?(hhuang)
(Assignee)

Updated

5 months ago
Assignee: evan → rchien
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

5 months ago
mozreview-review
Comment on attachment 8885140 [details]
Bug 1377315 - Update the search icon

https://reviewboard.mozilla.org/r/155998/#review161192
Attachment #8885140 - Flags: review?(dao+bmo) → review+

Comment 6

5 months ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7b57bda4387
Update the search icon r=dao

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b7b57bda4387
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED

Comment 8

4 months ago
Build ID: 20170808114032
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
You need to log in before you can comment on or make changes to this bug.