Closed Bug 1377328 Opened 2 years ago Closed 2 years ago

Add some ownership/lifetime annotations to raw pointers used in gfx font code

Categories

(Core :: Graphics: Text, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8882464 - Flags: review?(milan) → review?(ptheriault)
Attachment #8882465 - Flags: review?(milan) → review?(ptheriault)
Thanks for the quick turnaround Jonathan!  I'll get Paul to review this, 'cause the whole annotation thing...
Thanks very much for the quick turnaround Jonathan, sorry I was on leave until last week. I'll pass this review on to Julian.
Attachment #8882464 - Flags: review?(ptheriault) → review?(julian.r.hector)
Attachment #8882465 - Flags: review?(ptheriault) → review?(julian.r.hector)
Attachment #8882464 - Flags: review?(julian.r.hector) → feedback+
Comment on attachment 8882465 [details] [diff] [review]
part 2 - Annotate raw pointers used for refcounted objects in font-related code

Thank you for taking care of this so quickly. The comments with the explanation are exactly what we are looking for.

Since I am not a gfx peer, I can't really give the r+, or don't really feel comfortable doing so (even if it is just changes that involve clang plugin builds)
Attachment #8882465 - Flags: review?(julian.r.hector) → feedback+
Comment on attachment 8882464 [details] [diff] [review]
part 1 - Annotate some font-related helper classes as MOZ_STACK_CLASS

Thanks, Julian. Re-flagging Paul for r?...
Attachment #8882464 - Flags: review?(ptheriault)
Attachment #8882465 - Flags: review?(ptheriault)
Sorry I didn't notice this in my queue. I don't have anything further to add beyond what julian added (if it looks good to julian it looks good to me).
Comment on attachment 8882464 [details] [diff] [review]
part 1 - Annotate some font-related helper classes as MOZ_STACK_CLASS

Milan, are you the right person to r+ here (I'm not a gfx peer either, so I dont think I should, even though the patch here is for static analysis annotations?)
Attachment #8882464 - Flags: review?(ptheriault) → review?(milan)
Attachment #8882465 - Flags: review?(ptheriault) → review?(milan)
Attachment #8882464 - Flags: review?(milan) → review+
Attachment #8882465 - Flags: review?(milan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/14a81abc410200721f759d072ee67aa29c83afc0
Bug 1377328 - part 1 - Annotate some font-related helper classes as MOZ_STACK_CLASS. r=milan

https://hg.mozilla.org/integration/mozilla-inbound/rev/c00b89451c8d9bb7c8746e02c80c1ea1bb60f5d0
Bug 1377328 - part 2 - Annotate raw pointers used for refcounted objects in font-related code. r=milan
https://hg.mozilla.org/mozilla-central/rev/14a81abc4102
https://hg.mozilla.org/mozilla-central/rev/c00b89451c8d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.