Re-enable DRAWWINDOW_DRAW_VIEW and DRAWWINDOW_USE_WIDGET_LAYERS flags for Marionette screen captures

NEW
Unassigned

Status

Testing
Marionette
P3
normal
5 months ago
2 months ago

People

(Reporter: ato, Unassigned)

Tracking

Version 3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 months ago
As noted in a TODO in testing/marionette/capture.js, we have disabled two flags on the canvas context when taking screenshots:

>   let ctx = canvas.getContext(CONTEXT_2D);
>   if (flags === null) {
>     flags = ctx.DRAWWINDOW_DRAW_CARET;
>     // Disabled in bug 1243415 for webplatform-test
>     // failures due to out of view elements.  Needs
>     // https://github.com/w3c/web-platform-tests/issues/4383 fixed.
>     /*
>     ctx.DRAWWINDOW_DRAW_VIEW;
>     */
>     // Bug 1009762 - Crash in [@ mozilla::gl::ReadPixelsIntoDataSurface]
>     /*
>     ctx.DRAWWINDOW_USE_WIDGET_LAYERS;
>     */
>   }

We want to investigate re-enabling these.
You could try to test in a try push but the underlying crash is not fixed yet, and as such it should still appear.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.