Closed
Bug 1377353
Opened 7 years ago
Closed 7 years ago
nsUnknownDecoder::OnDataAvailable inconsistent use of mNextListener
Categories
(Core :: Networking: HTTP, enhancement)
Core
Networking: HTTP
Tracking
()
RESOLVED
INVALID
People
(Reporter: tnikkel, Unassigned)
References
Details
mNextListener is protected by a mutex, suggesting it can be changed on multiple threads. nsUnknownDecoder::OnDataAvailable null checks mNextListener, releases the mutex, then acquires the mutex and then uses mNextListener again. mNextListener could have been set to null after it was null checked.
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(dd.mozilla)
|
||
Comment 1•7 years ago
|
||
mNextListener is used by main thread(in onStartRequest ang OnStopRequest) and off main thread (onDataAvailable), but we guarantee that this functions are called in sequence. Therefore mutex is only that tsan do not complain. The situation from th description cannot happen.
Flags: needinfo?(dd.mozilla)
|
|
Reporter | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•