1377358 - browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled

Status: RESOLVED FIXED

(Firefox Graveyard :: Activity Streams: General, enhancement)

Description

[Ursula Sarracini (:ursula)]

We're now loading about:newtab in the content process when activity stream is enabled, and this causes some raciness to happen in this test. We'll check if the url is about:newtab and return early out of the callback to fix this.

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: Bug 1377358 - browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled

Review commit: https://reviewboard.mozilla.org/r/153590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153590/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8882462 [details]
Bug 1377358 - browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled

https://reviewboard.mozilla.org/r/153590/#review159034

::: browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js:162
(Diff revision 1)
> -        browser.test.log("onUpdate: " + JSON.stringify(changeInfo));
>          if ("url" in changeInfo) {
> +          // When activity stream is enabled, about:newtab runs in the content process
> +          // which causes some timing issues for onUpdated. So if we encounter
> +          // about:newtab, we return early out of the callback.
> +          if ("about:newtab" === changeInfo.url) {

We should still get the correct onUpdated event for about:blank after this, so we just need to return early from the listener, but not remove the listener or end the test.

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1377358 - browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled.

Review commit: https://reviewboard.mozilla.org/r/153908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153908/

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8882844 [details]
Bug 1377358 - browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled.

https://reviewboard.mozilla.org/r/153908/#review159036

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39754f1db01c
browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js fails when Activity Stream is enabled. r=kmag

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ecee4458990
followup, pacify eslint

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/39754f1db01c
https://hg.mozilla.org/mozilla-central/rev/8ecee4458990