Closed Bug 1377387 Opened 7 years ago Closed 7 years ago

Intermittent test_quit_restart.py TestServerQuitApplication.test_attempt_quit | application crashed [@ NS_CycleCollectorSuspect3]

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1381748

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: crash, intermittent-failure)

Crash Data

It looks like maybe WorkerPrivate::ClearMainEventQueue is being called on a thread where the CC was already shut down. Or was never initialized. And then it is releasing a CCed object (FileReader). Andrea, have there been any worker shutdown changes recently?
Flags: needinfo?(amarchesini)
We changed bits in the timing implementation but nothing in the shutting down procedure of workers.
Ben, can this crash related to some of your recent changes?
Flags: needinfo?(amarchesini) → needinfo?(bkelly)
It seems we expect all cycle collectable runnables to be emptied by this previous ClearMainEventQueue() call:

http://searchfox.org/mozilla-central/source/dom/workers/RuntimeService.cpp#2940

But apparently a timer is holding a reference to a callback that uses the CC'able FileReader.  It seems we should probably cancel all timers before we hit the line above.

We call CancelAllTimeouts() here, but perhaps we should call it one more time at the end of the primary loop.  What do you think?

http://searchfox.org/mozilla-central/source/dom/workers/WorkerPrivate.cpp#5675
Flags: needinfo?(bkelly) → needinfo?(amarchesini)
There is also an assertion present. Sorry that we have a bug for printing the stack still for Marionette tests:

[task 2017-07-06T23:05:06.487718Z] 23:05:06     INFO -  Assertion failure: data, at /home/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp:4032
[task 2017-07-06T23:05:06.488793Z] 23:05:06     INFO -  #01: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x4e04ad]
[task 2017-07-06T23:05:06.489778Z] 23:05:06     INFO -  #02: ???[/home/worker/workspace/build/application/firefox/libxul.so +0xca9769]
[task 2017-07-06T23:05:06.490459Z] 23:05:06     INFO -  #03: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x19877c1]
[task 2017-07-06T23:05:06.492181Z] 23:05:06     INFO -  #04: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x19e2d48]
[task 2017-07-06T23:05:06.493318Z] 23:05:06     INFO -  #05: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x537fda]
[task 2017-07-06T23:05:06.494319Z] 23:05:06     INFO -  #06: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54ed6f]
[task 2017-07-06T23:05:06.495158Z] 23:05:06     INFO -  #07: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x536467]
[task 2017-07-06T23:05:06.496174Z] 23:05:06     INFO -  #08: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54f417]
[task 2017-07-06T23:05:06.496891Z] 23:05:06     INFO -  #09: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54addf]
[task 2017-07-06T23:05:06.497940Z] 23:05:06     INFO -  #10: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x1f776f4]
[task 2017-07-06T23:05:06.498635Z] 23:05:06     INFO -  #11: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x1f77940]
[task 2017-07-06T23:05:06.499690Z] 23:05:06     INFO -  #12: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x1f25651]
[task 2017-07-06T23:05:06.500465Z] 23:05:06     INFO -  #13: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54f417]
[task 2017-07-06T23:05:06.501464Z] 23:05:06     INFO -  #14: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54aeda]
[task 2017-07-06T23:05:06.502224Z] 23:05:06     INFO -  #15: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x92168c]
[task 2017-07-06T23:05:06.503303Z] 23:05:06     INFO -  #16: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x8f2396]
[task 2017-07-06T23:05:06.504322Z] 23:05:06     INFO -  #17: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x8f23bb]
[task 2017-07-06T23:05:06.505011Z] 23:05:06     INFO -  #18: ???[/home/worker/workspace/build/application/firefox/libxul.so +0x54b0bc]
[task 2017-07-06T23:05:06.506036Z] 23:05:06     INFO -  #19: ???[/home/worker/workspace/build/application/firefox/libnspr4.so +0x252b0]
[task 2017-07-06T23:05:06.506816Z] 23:05:06     INFO -  #20: ???[/lib/i386-linux-gnu/libpthread.so.0 +0x6295]
[task 2017-07-06T23:05:06.507816Z] 23:05:06     INFO -  ExceptionHandler::GenerateDump cloned child 3307
[task 2017-07-06T23:05:06.508650Z] 23:05:06     INFO -  ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-07-06T23:05:06.509630Z] 23:05:06     INFO -  ExceptionHandler::WaitForContinueSignal waiting for continue signal...
(In reply to Andrew Truong [:feer56] [:andrewtruong] from comment #11)
> I've got a user on Facebook reporting crashes with this signature.
> https://www.facebook.com/Firefox/posts/
> 10159110813290022?comment_id=10159138867370022&comment_tracking=%7B%22tn%22%3
> A%22R9%22%7D

Could you file a new bug for that? It looks like some external DLL is running code that is interacting badly with Firefox. Here's an example of their crash reports: bp-46c37839-742f-43e1-ae39-971c20170723
This should be fixed by bug 1381748.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(amarchesini)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.