Closed
Bug 1377402
Opened 7 years ago
Closed 6 years ago
Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js | application crashed [@ mozilla::dom::SimpleGlobal_moved(JSObject*, JSObject const*)]
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 59
People
(Reporter: intermittent-bug-filer, Assigned: jonco)
Details
(Keywords: crash, intermittent-failure)
Crash Data
Attachments
(1 file)
1.15 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=110799709&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/Y2mrbyxqS-Sy-6yCM28wDg/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jcoppeard
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Assignee | ||
Comment 7•6 years ago
|
||
We need to null-check the JSObject's private pointer here in case initialisation failed before we set it.
Attachment #8940283 -
Flags: review?(sphink)
Comment 8•6 years ago
|
||
Comment on attachment 8940283 [details] [diff] [review] simple-global-object Review of attachment 8940283 [details] [diff] [review]: ----------------------------------------------------------------- I wish we had some static way of detecting partial initialization possibilities. Analyze the constructor function and notice that the private might be null, then somehow propagate that to... finalizers and move callbacks? Bleh, doesn't feel very general.
Attachment #8940283 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/611344d64ad7 Add null check in SimpleGlobalObject's class hooks r=sfink
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/611344d64ad7
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•