Closed Bug 1377420 Opened 3 years ago Closed 2 years ago

Add RTP RID test to the simulcast mochitest

Categories

(Core :: WebRTC: Networking, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

Attachments

(1 file)

Add a test to ensure that RTP Stream ID (RID) is being emitted correctly in the simulcast mochitest using the new packet dump superpowers.
Rank: 25
Priority: -- → P2
Attachment #8882523 - Flags: review?(drno)
Comment on attachment 8882523 [details]
Bug 1377420 - add RID check in RTP in simulcast mochitests

https://reviewboard.mozilla.org/r/153644/#review166386

::: dom/media/tests/mochitest/parser_rtp.js:51
(Diff revision 1)
> +  // Marker             1 Bit
> +  header.marker =  (0x80 & byte) >> 7;
> +  // Payload Type       7 Bit
> +  header.payloadType = (0x7F & byte);
> +  // Sequence Number   16 Bit
> +  header.sequenceNumber = view.getUint16(offset);

As you haven't increased the offset before this I think you are re-reading the marker and payload byte as the sequence number here.
Attachment #8882523 - Flags: review?(drno) → review+
Comment on attachment 8882523 [details]
Bug 1377420 - add RID check in RTP in simulcast mochitests

https://reviewboard.mozilla.org/r/153644/#review166386

> As you haven't increased the offset before this I think you are re-reading the marker and payload byte as the sequence number here.

I believe I am incrementing it at line 45 (and 34 previously).
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/b6fc02a83622
add RID check in RTP in simulcast mochitests r=drno
https://hg.mozilla.org/mozilla-central/rev/b6fc02a83622
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.