Closed Bug 1377527 Opened 5 years ago Closed 5 years ago

Failures in conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-float.html after ANGLE3118

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: daoshengmu, Unassigned)

References

Details

Attachments

(1 file)

After updateing to ANGLE3118, we got some failures that are related to WebGL texture conversion.

Ideally, we should unpack the src data according the src format to the intermediate format at https://dxr.mozilla.org/mozilla-central/rev/9af23c413a1f8d337b19b4f8450e241e91b71136/dom/canvas/WebGLTexelConversions.cpp#206.

However, because the mSurf of TexUnpackSurface is always DataSourceSurfaceD2D1, and its format is BGRA8. So, it always goes to unpack<WebGLTexelFormat::BGRA8, uint8_t, uint8_t>(const uint8_t* __restrict src, uint8_t* __restrict dst).

We should make a new unpack function for WebGLTexelFormat::RGB11F11F10F.
Blocks: 1371190
Summary: Failures in conformance2/textures/canvas_su b_rectangle/tex-2d-r11f_g11f_b10f-rgb-float.html after ANGLE3118 → Failures in conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-float.html after ANGLE3118
See Also: → 1325741
We seem to have already fixed this issue at Bug1325741. Let's see what's going on after applying the patches.
In ANGLE3118, Google has made several refractoring and architectural changes which make the patch in bug 1325741 very hard to apply, I am now trying to figure out how to re-apply it to ANGLE3118 manually.
I have pushed a branch with ANGLE3118 updated to github but without the patch in bug 1325741.
https://github.com/subsevenx2001/gecko-dev/tree/ANGLE3118np

This changeset in ANGLE refactored internalFormat utility function which make this patch unable to apply.
https://github.com/google/angle/commit/ca27139e6bdcca9afe8c041ee3cb8b5f57c51b38

And here is the changeset of Bug1325741 in github.
https://github.com/mozilla/gecko-dev/commit/ab9fcfb7eecb56bb1a93e19972d346fe6039da55
Flags: needinfo?(jgilbert)
We seem to do something mistake when rebasing the patch of Bug1325741 to ANGLE3118. After applying this patch, this test will run succesfully
No longer needs this ni, I have fixed it.
Flags: needinfo?(jgilbert)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.