137753 - "timewarp"ing from "All Checkins" (showcheckins.cgi) list (current hook) to previous hook

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, enhancement)

Description

[Robert Kaiser]

I'm using "All Checkins"
http://bonsai.mozilla.org/showcheckins.cgi?&treeid=SeaMonkey
quite often just to look what checkins we had.

The problem is, sometimes the tree closed and opened again since the last time I
looked into that list, and if I want to see the checkins fron the hook before
the current one, I have to click "Back to the top of Bonsai", then "Time Warp",
mark the last hoop, submit the form, and select "All Chekcins" again - that's
quite a lot to do for that simple task, IMO.

So here's my idea to make that better (and I think there's more people than just
me who would like that feature):
Beneath "Back to the top of Bonsai" (or before that=), just add a link "Show
checkins of previous hook" (or "Time Warp to previous hook's checkins"?) on the
"All Checkins" page, that would make my/our life much easier.

Comment 1

[Robert Kaiser]

Wow, I know a bit of perl but I can't really understand that code...

I'd guess we know the current shown batchID somewhere so we'd only have to link
to showcheckins.cgi with the same tree and batchID-1 when sowing a "normal" All
Checkins page.

Isn't there anyone out there who's interested in that and knows enough Perl or
enough of that bonsai code?

Comment 2

[Robert Kaiser]

One other case where I noted this to be a nice thing to have:
When the tree has just opened, the current list is empty (or has only one or two
new entries of fast people), but usually I want to look what has been checked in
since my last build... - so again I have to go up, timewarp, and list chackins
again...
(also making summary reflect better what I really want)

Comment 3

[timeless]

Attachment: patch

viewold is taught how to handle showcheckins.
showcheckins and toplevel are given a way to reach the current hook.

Comment 4

[timeless]

.

Comment 5

[Robert Kaiser]

timeless, thanks, this looks like a good idea how to do it, and even with a
patch, very nice!

I hope we'll get it reviewed and checked in soon ;-)

Comment 6

[timeless]

checked in

Comment 7

[Robert Kaiser]

OK, this is checked in as we can see on
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webtools/bonsai/showcheckins.cgi

But it's still not on bonsai.mozilla.org - any chance this might get updated?
Who can do that?