Closed
Bug 1377566
Opened 7 years ago
Closed 7 years ago
IonBuilder::ensureDefiniteTypeSet is not used
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
|
3.03 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
there's no callsite for IonBuilder::ensureDefiniteTypeSet. we can just remove it or use it where appropriate.
|
Assignee | |
Comment 3•7 years ago
|
||
so, this is added in bug 953164, and was used in IonBuilder::filterTypesAtTest that no more exist. I'll remove this
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•7 years ago
|
||
Just removed unused definition/declaration.
Attachment #8894801 -
Flags: review?(jdemooij)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8894801 [details] [diff] [review] Remove unused IonBuilder::ensureDefiniteTypeSet. Review of attachment 8894801 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8894801 -
Flags: review?(jdemooij) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9839ea550229 Remove unused IonBuilder::ensureDefiniteTypeSet. r=jandem
|
|
Assignee | |
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9839ea55022977fbe020d77939f2c9b5d541fe5f Bug 1377566 - Remove unused IonBuilder::ensureDefiniteTypeSet. r=jandem
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9839ea550229
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•