IonBuilder::ensureDefiniteTypeSet is not used

RESOLVED FIXED in Firefox 57

Status

()

enhancement
--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
there's no callsite for IonBuilder::ensureDefiniteTypeSet.
we can just remove it or use it where appropriate.
(Assignee)

Comment 1

2 years ago
I might use it in bug 1366263.
See Also: → 1366263
(Assignee)

Comment 2

2 years ago
I didn't use it in bug 1366263.
See Also: 1366263
(Assignee)

Comment 3

2 years ago
so, this is added in bug 953164, and was used in IonBuilder::filterTypesAtTest that no more exist.
I'll remove this
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
Just removed unused definition/declaration.
Attachment #8894801 - Flags: review?(jdemooij)
Comment on attachment 8894801 [details] [diff] [review]
Remove unused IonBuilder::ensureDefiniteTypeSet.

Review of attachment 8894801 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8894801 - Flags: review?(jdemooij) → review+

Comment 6

2 years ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9839ea550229
Remove unused IonBuilder::ensureDefiniteTypeSet. r=jandem

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9839ea550229
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.