Closed
Bug 1377578
Opened 7 years ago
Closed 7 years ago
TPS Tab and Addon tests fail
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: tcsc, Assigned: tcsc)
Details
Attachments
(1 file)
Specifically, the tests that are failing in: test_tabs.js, test_bug535326.js, test_bug546807.js, test_privbrw_tabs.js, test_special_tabs.js, test_addon_restartless_xpi.js, test_addon_nonrestartless_xpi.js, test_addon_reconciling.js, test_addon_wipe.js, and test_existing_bookmarks.js. These are caused because of the removal of the third argument to AddonUtils.updateUserDisabled, and to not taking a safe approach to waiting for a tab to load (e.g. not the approach taken by BrowserTestUtils. Patch incoming.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8882709 [details] Bug 1377578 - Fix TPS to keep it's addons and tabs tests passing . https://reviewboard.mozilla.org/r/153792/#review158972 ::: services/sync/tests/tps/test_tabs.js:24 (Diff revision 1) > var tabs1 = [ > { uri: "http://mozqa.com/data/firefox/layout/mozilla.html", > title: "Mozilla", > profile: "profile1" > }, > - { uri: "data:text/html,<html><head><title>Hello</title></head><body>Hello</body></html>", > + { uri: "data:text/html;charset=utf-8," + encodeURIComponent("<html><head><title>Hello</title></head><body>Hello</body></html>"), as discussed, remove the changes in this file.
Attachment #8882709 -
Flags: review?(markh) → review+
| Comment hidden (mozreview-request) |
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcd993ae70bc Fix TPS to keep it's addons and tabs tests passing r=markh.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bcd993ae70bc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•