If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Expose security certificate information in GV-based custom tabs

RESOLVED FIXED in Firefox 57

Status

()

Product:
Firefox for Android
Component:
General
RESOLVED FIXED
Reported:
3 months ago
Modified:
a month ago

People

(Reporter: droeh, Assigned: droeh)

Tracking

Version:
53 Branch
Target:
Firefox 57
All
Android
Points:
---
Duplicates:
1388058

Firefox Tracking Flags

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

Attachments

(1 attachment)

Expose security certificate information in custom tabs
25.19 KB, patch
snorp
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
3 months ago 
I currently have a patch up (for bug 1376587) which exposes much more security information in ProgressListener.onSecurityChange() in a GeckoBundle (keys/values documented in GeckoView.java). This GeckoBundle is compatible with SiteIdentity.update(), so it should be easy enough to build a SiteIdentity in CustomTabsActivity and restore some of the old ActionBarPresenter code.
 (Assignee)

Updated

•
3 months ago
Depends on: 1376587
 (Assignee)

Updated

•
2 months ago
Duplicate of this bug: 1388058
 (Assignee)

Comment 2

•
2 months ago 
Created attachment 8895845 [details] [diff] [review]
Expose security certificate information in custom tabs

This adds a class, CustomTabsSecurityPopup, a bit similar to SiteIdentityPopup used by Fennec, to display security cert information when a user taps on the security icon in a custom tab.
Assignee: nobody → droeh
Attachment #8895845 - Flags: review?(snorp)
Attachment #8895845 - Flags: review?(snorp) → review+
tracking-fennec: --- → +
status-firefox56: --- → unaffected
status-firefox57: --- → affected

Comment 3

•
2 months ago 
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e74b401083
Expose security information in custom tabs. r=snorp

Comment 4

•
2 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/50e74b401083
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
status-firefox55: --- → unaffected
You need to log in before you can comment on or make changes to this bug.