Closed Bug 1377583 Opened 3 years ago Closed 3 years ago

Expose security certificate information in GV-based custom tabs

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Version:
53 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: droeh, Assigned: droeh)

References

Details

Attachments

(1 file)

Expose security certificate information in custom tabs
25.19 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
I currently have a patch up (for bug 1376587) which exposes much more security information in ProgressListener.onSecurityChange() in a GeckoBundle (keys/values documented in GeckoView.java). This GeckoBundle is compatible with SiteIdentity.update(), so it should be easy enough to build a SiteIdentity in CustomTabsActivity and restore some of the old ActionBarPresenter code.
Depends on: 1376587
Duplicate of this bug: 1388058
This adds a class, CustomTabsSecurityPopup, a bit similar to SiteIdentityPopup used by Fennec, to display security cert information when a user taps on the security icon in a custom tab.
Assignee: nobody → droeh
Attachment #8895845 - Flags: review?(snorp)
Attachment #8895845 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50e74b401083
Expose security information in custom tabs. r=snorp
https://hg.mozilla.org/mozilla-central/rev/50e74b401083
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.