Intermittent testGCFinalizeCallback | js/src/jsapi-tests/testGCFinalizeCallback.cpp:49:CHECK failed: !cx->runtime()->gc.isFullGc() in Windows XP CGC build

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript: GC
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: jonco, Assigned: sfink)

Tracking

55 Branch
mozilla56
x86
Windows XP
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
This is probably because of the zeal setting interfering with the test's expectation of when GC happens.
(Reporter)

Comment 1

4 months ago
https://treeherder.mozilla.org/logviewer.html#?job_id=111226486&repo=try&lineNumber=21355
(Reporter)

Updated

4 months ago
Assignee: nobody → jcoppeard
(Assignee)

Comment 2

4 months ago
Created attachment 8883062 [details] [diff] [review]
Prevent GC test from seeing unwanted all-zones GCs due to zeal
Attachment #8883062 - Flags: review?(jcoppeard)
(Assignee)

Updated

4 months ago
Assignee: jcoppeard → sphink
Status: NEW → ASSIGNED
(Reporter)

Comment 3

4 months ago
Comment on attachment 8883062 [details] [diff] [review]
Prevent GC test from seeing unwanted all-zones GCs due to zeal

Review of attachment 8883062 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Also could have used AutoLeaveZeal from tests.h.
Attachment #8883062 - Flags: review?(jcoppeard) → review+
(Reporter)

Comment 4

4 months ago
I'm seeing this failing a lot in my try pushes so I'm going to go ahead and land it.

Comment 5

4 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9aef6ee183
Prevent GC test from seeing unwanted all-zones GCs due to zeal r=jonco

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d9aef6ee183
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.