Closed Bug 1377593 Opened 3 years ago Closed 3 years ago

Intermittent testGCFinalizeCallback | js/src/jsapi-tests/testGCFinalizeCallback.cpp:49:CHECK failed: !cx->runtime()->gc.isFullGc() in Windows XP CGC build

Categories

(Core :: JavaScript: GC, enhancement)

55 Branch
x86
Windows XP
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jonco, Assigned: sfink)

Details

Attachments

(1 file)

This is probably because of the zeal setting interfering with the test's expectation of when GC happens.
Assignee: nobody → jcoppeard
Assignee: jcoppeard → sphink
Status: NEW → ASSIGNED
Comment on attachment 8883062 [details] [diff] [review]
Prevent GC test from seeing unwanted all-zones GCs due to zeal

Review of attachment 8883062 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Also could have used AutoLeaveZeal from tests.h.
Attachment #8883062 - Flags: review?(jcoppeard) → review+
I'm seeing this failing a lot in my try pushes so I'm going to go ahead and land it.
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9aef6ee183
Prevent GC test from seeing unwanted all-zones GCs due to zeal r=jonco
https://hg.mozilla.org/mozilla-central/rev/2d9aef6ee183
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.